[move-only] Emit a clearer message around deinits. #64289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gottesmm
requested review from
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor and
rintaro
as code owners
|
@swift-ci smoke test |
gottesmm
force-pushed
the
pr-bad04a239d63b44e8fd169d5bf8f2cd1baf19542
branch
from
74d6259 to
f83c85a
Compare
|
@swift-ci smoke test |
gottesmm
force-pushed
the
pr-bad04a239d63b44e8fd169d5bf8f2cd1baf19542
branch
from
f83c85a to
eddcf67
Compare
|
@swift-ci smoke test |
gottesmm
force-pushed
the
pr-bad04a239d63b44e8fd169d5bf8f2cd1baf19542
branch
from
eddcf67 to
44c30aa
Compare
|
@swift-ci smoke test |
Specifically: 1. Fix the error message so that when we say you can't have a deinit that a deinit can be on a noncopyable type along side a class or an actor. 2. Even though we already error on @objc enums and say they cannot be noncopyable, we did not emit an error on the deinit saying that @objc enums cannot have a deinit. I put in a nice to have error just to make it even clearer. rdar://105855978 rdar://106566054
gottesmm
force-pushed
the
pr-bad04a239d63b44e8fd169d5bf8f2cd1baf19542
branch
from
44c30aa to
40449a6
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically:
Fix the error message so that when we say you can't have a deinit that a deinit can be on a noncopyable type along side a class or an actor.
Even though we already error on @objc enums and say they cannot be noncopyable, we did not emit an error on the deinit saying that @objc enums cannot have a deinit. I put in a nice to have error just to make it even clearer.
rdar://105855978
rdar://106566054