[cxx-interop] Apply typedef -> enum patch to method param types as well. #42452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically just applying swiftlang#42431 to ObjC method param tyeps.
|
@swift-ci please test. |
|
@swift-ci Please Test Source Compatibility |
plotfi
reviewed
Apr 19, 2022
plotfi
reviewed
Apr 19, 2022
| @@ -2847,7 +2865,21 @@ ImportedType ClangImporter::Implementation::importMethodParamsAndReturnType( | |||
| ImportTypeKind importKind = ImportTypeKind::Parameter; | |||
| ImportDiagnosticAdder paramAddDiag(*this, clangDecl, param->getLocation()); | |||
| Type swiftParamTy; | |||
| bool paramIsIUO; | |||
| bool paramIsIUO = false; | |||
| if (auto typedefType = dyn_cast<clang::TypedefType>(paramTy.getTypePtr())) { | |||
There was a problem hiding this comment.
Can this and the previous addition be merged into one function or lambda?
There was a problem hiding this comment.
Good idea. I will do it in a follow-up nfc.
plotfi
reviewed
Apr 19, 2022
|
|
||
| // CHECK: class ColorMaker { | ||
| // CHECK: class func makeColor(withOptions opts: SOColorMask) | ||
| // CHECK: func makeColor(withOptions opts: SOColorMask) |
There was a problem hiding this comment.
I suspect you will have to update these now that #42412 is merged.
|
Windows test failures are unrelated. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically just applying #42431 to ObjC method param types.