Skip to content

[Sema] Consider more paths in the SDK as defining private modules #42432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2022

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Apr 18, 2022

Consider both frameworks and free floating modules imported from more
private paths as SPI modules. This will make the compiler raise errors on public
imports of more private modules.

rdar://91904154

xymus added 3 commits April 18, 2022 14:36
Consider both frameworks and free floating modules imported from more
private path as SPI. This will make the compiler raise errors on public
imports of more private modules.

rdar://91904154
@xymus xymus requested a review from nkcsgexi April 18, 2022 21:43
@xymus
Copy link
Contributor Author

xymus commented Apr 18, 2022

@swift-ci Please smoke test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, Thank you for fixing it!

@xymus xymus merged commit 29cd551 into swiftlang:main Apr 19, 2022
@xymus xymus deleted the consider-more-paths-as-spi branch April 19, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants