Rename _MatchingEngine module to _RegexParser #42081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
approved these changes
Mar 29, 2022
|
rxwei
force-pushed
the
rename-matchingengine-module
branch
2 times, most recently
from
fe20e06 to
06bf6c3
Compare
rxwei
changed the title
rxwei
force-pushed
the
rename-matchingengine-module
branch
2 times, most recently
from
9d9a1ab to
4e543e2
Compare
rintaro
reviewed
Mar 30, 2022
| add_swift_compiler_module(ExperimentalRegex | ||
| "${LIBSWIFT_EXPERIMENTAL_REGEX_SOURCES}" | ||
| Regex.swift) | ||
|
|
There was a problem hiding this comment.
I guess you accidentally deleted this and the Regex.swift source
There was a problem hiding this comment.
Good catch! Forgot to git add.
|
I assume |
It's not supposed to be importable. We plan to strip out the the module files when installing _RegexParser. I'll look into that next, let me get back to you on this before merging. |
rxwei
force-pushed
the
rename-matchingengine-module
branch
from
4e543e2 to
93d42d4
Compare
rintaro
approved these changes
Mar 31, 2022
rxwei
added a commit
to swiftlang/swift-installer-scripts
that referenced
this pull request
Mar 31, 2022
This change was introduced in swiftlang/swift#42081.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the _MatchingEngine module no longer contains the matching engine, this patch renames this module to describe its role more accurately. Because this module primarily contains the AST and the regex parsing logic, I propose we rename it to "_RegexParser".
Also renames the ExperimentalRegex module in SwiftCompilerSources to _RegexParser for consistency. This would prevent errors if sources in _RegexParser used qualified lookup with the module name.