Skip to content

Add a flag to disable compile-time preallocated instantiation caches (for type metadata and protocol conformances) #41148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

kubamracek
Copy link
Contributor

The motivation is to save codesize in generated binaries when it's appropriate to trade off some performance for better codesize. The intention is to enable this for the "minimal" / "freestanding" preset.

…(for type metadata and protocol conformances)
@kubamracek
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@mikeash mikeash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Can we have a runtime test that also exercises -disable-preallocated-instantiation-caches to make sure that side of things works (and keeps working)?

@kubamracek
Copy link
Contributor Author

Looks great! Can we have a runtime test that also exercises -disable-preallocated-instantiation-caches to make sure that side of things works (and keeps working)?

There already is one in the PR! (There's two tests, one IR test, one runtime test). Or are you looking for another test for something not covered?

@mikeash
Copy link
Contributor

mikeash commented Feb 2, 2022

@kubamracek Argh, sorry. I swear I looked at them both but I must have looked at the other one twice instead. This looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants