[TypeChecker] Prevent pattern resolution from triggering type-checking for unresolved references #39399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
approved these changes
Sep 22, 2021
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
hborla
approved these changes
Sep 22, 2021
| if (cs.isDebugMode()) { | ||
| auto &log = llvm::errs(); | ||
|
|
||
| log << "--- Applying result builder to function ---\n"; |
There was a problem hiding this comment.
Nice, this will be super helpful in debug-constraints output 🙂
There was a problem hiding this comment.
Yeah, it's going to be a good indicator what is being processed piecemeal, otherwise it's sometimes unclear where the sub-targets are coming from...
|
@swift-ci please smoke test Windows platform |
…g for unresolved references Workaround for Clang enum typaliases called `isInvalid()` and `getInterfaceType()` on discovered declarations. That doesn't play well with result builders because declarations/patterns used in the body of a result builder don't get a type until a solution is applied. Calling `isInvalid()` or `getInterfaceType` on declarations located in the body of a result builder trigger a separate type-check for the declaration that interferes with builder transformation and leads to crashes.
xedin
force-pushed
the
result-builder-switch
branch
from
690cb80 to
3710967
Compare
|
I have changed to check for |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows platform |
…rEnumElement` Since re-declaration error is going to be emitted anyway it doesn't matter which declaration would get returned.
|
@swift-ci please smoke test |
|
As suggested by @slavapestov removed both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for Clang enum typaliases called
isInvalid()andgetInterfaceType()on discovered declarations. That doesn't play well with result builders because
declarations/patterns used in the body of a result builder don't get a type until
a solution is applied. Calling
isInvalid()orgetInterfaceTypeon declarationslocated in the body of a result builder trigger a separate type-check for the
declaration that interferes with builder transformation and leads to crashes.