Skip to content

Revert "Start using optimization (-O0/-O2/-O3/-Os) and debug (-g) flags from CMAKE_CXX_FLAGS_${CFLAGS_BUILD_TYPE} (#33388)" #33924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2020

Conversation

kubamracek
Copy link
Contributor

@kubamracek kubamracek commented Sep 12, 2020

Reverting because of #33896 which is a big oversight. Better re-try landing the whole thing.

…gs from CMAKE_CXX_FLAGS_${CFLAGS_BUILD_TYPE} (swiftlang#33388)"

This reverts commit 28a2826.
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@gottesmm
Copy link
Contributor

If this passes without issue with the tests, LGTM.

@kubamracek kubamracek changed the title Revert https://github.com/apple/swift/pull/33388 [Start using optimization (-O0/-O2/-O3/-Os) and debug (-g) flags from CMAKE_CXX_FLAGS_${CFLAGS_BUILD_TYPE}] Revert PR#33388 - Start using optimization (-O0/-O2/-O3/-Os) and debug (-g) flags from CMAKE_CXX_FLAGS_${CFLAGS_BUILD_TYPE} Sep 12, 2020
@kubamracek kubamracek changed the title Revert PR#33388 - Start using optimization (-O0/-O2/-O3/-Os) and debug (-g) flags from CMAKE_CXX_FLAGS_${CFLAGS_BUILD_TYPE} Revert "Start using optimization (-O0/-O2/-O3/-Os) and debug (-g) flags from CMAKE_CXX_FLAGS_${CFLAGS_BUILD_TYPE} (#33388)" Sep 12, 2020
@kubamracek kubamracek merged commit d9d929a into swiftlang:master Sep 12, 2020
@kubamracek kubamracek deleted the revert-28a2826 branch September 12, 2020 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants