[Property Wrappers] Improve diagnostics for property wrappers initialized out-of-line #32672
Conversation
initialized wrapped property via SolutionApplicationTarget.
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
anchored at a TypeRepr rather than an Expr.
via SolutionApplicationTarget. This allows fixes to be applied and diagnosed for better error messages in the case of failures, and removes code duplication for generating property wrapper constraints.
…ppers to produce better diagnostics when there's a 'wrappedValue' type mismatch.
handle all errors with a property wrapper backing type.
hborla
force-pushed
the
property-wrapper-diagnostics
branch
from
b7cdce0 to
9b4f1f0
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci please test Windows Platform |
| @@ -11,5 +11,5 @@ struct B { | |||
| } | |||
|
|
|||
| struct C { | |||
| @A @B var foo: Int // expected-error{{extraneous argument label 'wrappedValue:' in call}} | |||
| @A @B var foo: Int // expected-error{{composed wrapper type 'B' does not match former 'wrappedValue' type 'Int'}} | |||
There was a problem hiding this comment.
I don't understand this diagnostic... what are the two types facing a mismatch? Which wrappedValue is former 'wrappedValue' referring to here?
There was a problem hiding this comment.
For property wrapper composition @A @B the type of A.wrappedValue (which in this case is Int) must be equal to B. The generalization is that a composed wrapper type must match the wrappedValue type of the previous property wrapper. Does that make sense?
I would love to workshop this error message, and an educational note would be great too!
There was a problem hiding this comment.
I also want to add a note for this error message to have a note pointing to the wrappedValue declaration, but I need to add a new locator to support that so I figured it'd be better to do that in a separate PR. A new locator would also allow us to write the former property wrapper type in the error message itself
There was a problem hiding this comment.
Ok, that makes sense. I agree we should have some mention of A here; since wrappedValue itself is the standard name, it doesn't provide much context. For example (straw-man suggestion)
composed wrapper type 'B' does not match the type of 'A.wrappedValue' which is 'Int'
note: in a property wrapper composition, the type of an outer property wrapper's wrappedValue must match the type of the inner property wrapper
Addressing this in a subsequent PR SGTM. 😄
There was a problem hiding this comment.
I like that suggestion, thank you!
SolutionApplicationTargetwith fixes enabled in the constraint system to produce targeted diagnostics for specific failures, rather than the vagueproperty type does not match that of the 'wrappedValue' property of its wrapper typeerror message. This error message is now a fallback diagnostic for property wrappers.wrappedValuetype doesn't match the property or composed property wrapper type.Resolves: rdar://problem/54491433