Skip to content

Revert "Emit coverage mappings for all modules" #32303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

compnerd
Copy link
Member

Reverts #32216

@compnerd
Copy link
Member Author

CC: @keith

@compnerd
Copy link
Member Author

@swift-ci please smoke test

@keith
Copy link
Member

keith commented Jun 10, 2020

Can you post the error you saw so I can try to submit an update after this merges?

@compnerd
Copy link
Member Author

compnerd commented Jun 10, 2020

@keith - they are available on the CI status page from Jenkins: https://ci-external.swift.org/job/swift-PR-windows/4045/consoleText (the builds are supposed to trigger but the infrastructure has been having issues so it sometimes doesn't trigger and requires explicitly triggering).

@keith
Copy link
Member

keith commented Jun 10, 2020

Any general suggestions for testing on Windows without access to a windows machine?

@compnerd
Copy link
Member Author

VMs work as well (you can grab a VM from Microsoft: https://developer.microsoft.com/en-us/windows/downloads/virtual-machines). Most of the issues are usually pretty apparent from the error from CI.

@keith
Copy link
Member

keith commented Jun 10, 2020

Yea I understand the failure from the log, but don't understand why it would differ on Windows, I'll try and download the VM to debug.

@compnerd compnerd merged commit 122deaa into master Jun 11, 2020
@compnerd compnerd deleted the revert-32216-ks/coverage-modules branch June 11, 2020 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants