[build] re-enable setting soname for Android shared libraries #30956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@drodriguez, let me know what you think. |
|
@CodaFi, this fixes the Android SDK and anyone can review it, as it's very basic. It would be good to get this in before the 5.3 branch, very safe as only affects Android. |
|
@swift-ci smoke test |
|
Another spurious linux CI failure. |
|
@swift-ci smoke test linux |
|
Ping, passes all CI, ready to merge. |
drexin
approved these changes
Apr 17, 2020
|
Thanks, I've been trying to get this fixed for a couple months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to do the same as #30020, but given that was reverted for some "internal CI failure" at Apple, #30846, this one only adds back the flags for Android. This way, they can re-enable the remaining dropped Apple and ELF linker flags at their own pace.
@compnerd, this
shouldfixes the stdlib and other target libraries for Android, let me know.