Fix SynthesizedFileUnit serialization and TBDGen issues. #30912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `SynthesizedFileUnit` attached to a `SourceFile`. This seemed like the least ad-hoc approach to avoid doing unnecessary work for other `FileUnit`s. TBDGen: when visiting a `SourceFile`, also visit its `SynthesizedFileUnit` if it exists. Serialization: do not treat `SynthesizedFileUnit` declarations as xrefs when serializing the companion `SourceFile`. Resolves TF-1239: AutoDiff test failures.
Upstream `SynthesizedFileUnit` failing tests from TF-1239.
|
This continues Some context: the SILOptimizer differentiation transform generates both struct and enum declarations and adds them to a Related discussion about generating declarations in SILOptimizer: #30736 (comment) |
|
@swift-ci Please test |
dan-zheng
commented
Apr 9, 2020
rxwei
approved these changes
Apr 9, 2020
|
Merging to unblock progress. Happy to address any feedback later! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
SynthesizedFileUnitserialization and TBDGen issues exposed in TF-1239.Make
SynthesizedFileUnitattached to aSourceFile. This seemed like theleast ad-hoc approach to avoid doing unnecessary work for other
FileUnits.TBDGen: when visiting a
SourceFile, also visit itsSynthesizedFileUnitifit exists.
Serialization: do not treat
SynthesizedFileUnitdeclarations as xrefs whenserializing the companion
SourceFile.Upstream AutoDiff tests validating that TF-1239 is fixed.
Unblocks end-to-end differentiation, particularly cross-module compilation use cases.