Skip to content

Move the FSO bailout to the beginning of the pass. #30466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Move the FSO bailout to the beginning of the pass. #30466

merged 1 commit into from
Mar 18, 2020

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Mar 18, 2020

This way we catch the DeadFunctionArgs optimization too, which is a
separate sub-pass.

[Part of the series of already-approved pass manager commits from:
https://github.com//pull/22445]

This way we catch the DeadFunctionArgs optimization too, which is a
separate sub-pass.
@atrick
Copy link
Contributor Author

atrick commented Mar 18, 2020

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 80d502c

@atrick
Copy link
Contributor Author

atrick commented Mar 18, 2020

@swift-ci smoke test linux

1 similar comment
@atrick
Copy link
Contributor Author

atrick commented Mar 18, 2020

@swift-ci smoke test linux

@atrick
Copy link
Contributor Author

atrick commented Mar 18, 2020

@swift-ci benchmark

@swift-ci
Copy link
Contributor

Performance: -O

Improvement OLD NEW DELTA RATIO
DataReplaceMediumBuffer 10100 9400 -6.9% 1.07x (?)

Code size: -O

Performance: -Osize

Improvement OLD NEW DELTA RATIO
DictionaryBridgeToObjC_Access 923 765 -17.1% 1.21x (?)

Code size: -Osize

Performance: -Onone

Improvement OLD NEW DELTA RATIO
ObjectiveCBridgeStubFromNSDateRef 4830 4390 -9.1% 1.10x (?)

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@atrick atrick merged commit 3462935 into swiftlang:master Mar 18, 2020
@atrick atrick deleted the fix-fso-bailout branch March 18, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants