IRGen: Use clang's objc encoding for types when there is a ClangNode #30438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do this because the swift code does not support all attributes and does not support generics. rdar://60474785
|
@swift-ci Please test |
DougGregor
reviewed
Mar 17, 2020
aschwaighofer
added a commit
to aschwaighofer/swift
that referenced
this pull request
Mar 26, 2020
…lso_unique_ext_method_types_list" This reverts commit f0cdd76, reversing changes made to 703fe0f. Revert "IRGen: Refactor getObjCEncodingForMethod and getObjectEncodingFromClangNode into one" This reverts commit 0082682. Revert "Merge pull request swiftlang#30438 from aschwaighofer/irgen_prefer_clang_type_encoding" This reverts commit eeb7fa5, reversing changes made to 77af77f. Revert "Merge pull request swiftlang#30433 from aschwaighofer/irgen_no_duplicate_objc_method_descriptor_entries" This reverts commit 77af77f, reversing changes made to 841eeb0. This reverts the changes for rdar://60461850, rdar://60474785, rdar://60778637 There is still at least an issue that we address with PR#30654. Revert until we have confidence that this is the right fix set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do this because the swift code does not support all attributes and
does not support generics.
rdar://60474785