Skip to content

[PrintAsObjC] Don't print imports for empty extensions #30306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 9, 2020

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Mar 9, 2020

Fix an issue in generated compatibility headers where an extension that is not printed would still trigger the inclusion of the extended type's origin module. This was mostly noticeable with @implementationOnly imports when imported types were extended with only private members.

rdar://problem/57133517

@xymus xymus requested a review from beccadax March 9, 2020 21:28
@xymus
Copy link
Contributor Author

xymus commented Mar 9, 2020

@swift-ci Please smoke test

@xymus xymus changed the title [PrintAsObjC] Don't print imports for extensions to @implementationOnly types [PrintAsObjC] Don't print imports for empty extensions Mar 9, 2020
Copy link
Contributor

@beccadax beccadax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xymus xymus merged commit 685d35b into swiftlang:master Mar 9, 2020
@xymus xymus deleted the print-objc-ext branch October 31, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants