Skip to content

[CMake] Move the _add_swift_target_library_single() call for BlocksRuntimeStub under the SWIFT_BUILD_STDLIB check #30275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

akyrtzi
Copy link
Contributor

@akyrtzi akyrtzi commented Mar 7, 2020

Since the stub for BlocksRuntime library is to "be used for the reflection tests", don't set it up unless the reflecting tests are also setup.

…sRuntimeStub` under the `SWIFT_BUILD_STDLIB` check

Since the stub for BlocksRuntime library is to "be used for the reflection tests", don't set it up unless the reflecting tests are also setup.
@akyrtzi
Copy link
Contributor Author

akyrtzi commented Mar 7, 2020

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Mar 7, 2020

Build failed
Swift Test Linux Platform
Git Sha - 85a5e5a

@akyrtzi
Copy link
Contributor Author

akyrtzi commented Mar 7, 2020

@swift-ci test linux platform

@akyrtzi
Copy link
Contributor Author

akyrtzi commented Mar 7, 2020

@swift-ci test Windows platform

@akyrtzi
Copy link
Contributor Author

akyrtzi commented Mar 7, 2020

test failure on windows shows up in master as well

@akyrtzi akyrtzi merged commit 9afa37e into swiftlang:master Mar 7, 2020
@akyrtzi akyrtzi deleted the cmake-blocks-runtime-under-stdlib branch March 7, 2020 20:14
@compnerd
Copy link
Member

compnerd commented Mar 8, 2020

Good call :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants