Emit debug info for generic type aliases. … #29699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Build failed |
dcci
approved these changes
Feb 7, 2020
|
ugh. |
slavapestov
approved these changes
Feb 7, 2020
|
Build failed |
|
This is quite interesting. By changing this, we also prefer the decl types of bound generic types, so we end up with types like struct<τ_0_0> instead of struct in the debug info. I think what I really want to do is collect all the type aliases in the decl type and reverse-substitute them in the SIL type. |
Before comparing the potential sugared type for equality is needs to be mapped into the context to resolve generic type parameters to primary archetypes. <rdar://problem/59238327>
adrian-prantl
force-pushed
the
59238327
branch
from
9d1d652 to
e932580
Compare
|
Found a much simpler fix... used the mapped type instead of the decl type. |
|
@swift-ci test and merge |
1 similar comment
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before comparing the potential sugared type for euqality is needs to be mapped
into the context to resolve generic type parameters to primary archetypes.
rdar://problem/59238327