[AutoDiff upstream] Add @noDerivative flag to SILParameterInfo.
#29405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `@noDerivative` attribute marks the non-differentiability parameters of a `@differentiable` function type. All parameters except those marked with `@noDerivative` are differentiability parameters. For example, `@differentiable (Float, @noDerivative Float) -> Float` is only differentiable with respect to its first parameter. The `@noDerivative` attribute is represented as a `SILParameterDifferentiability` bit on `SILParameterInfo`. Add round-trip serialization tests. Resolves TF-872.
Add SILGen test.
|
@swift-ci Please test |
|
@jckarter: would you like to review this PR, or suggest a reviewer? I'm asking you since you seem like a SIL code owner. This PR is part of our effort to upstream differentiable programming. It lowers an existing AST flag to SIL and should be relatively non-controversial. If there's no activity, I'll merge within a day to unblock progress. Happy to address feedback at any time! |
rxwei
approved these changes
Jan 24, 2020
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@noDerivativeattribute marks the non-differentiability parameters of a@differentiablefunction type. All parameters except those marked with@noDerivativeare differentiability parameters.For example,
@differentiable (Float, @noDerivative Float) -> Floatis onlydifferentiable with respect to its first parameter.
The
@noDerivativeattribute is represented as aSILParameterDifferentiabilitybit onSILParameterInfo.The existing
@noDerivativeAST attribute is now lowered to SIL.Add round-trip serialization and SILGen tests.
Resolves TF-872.