Skip to content

[Incremental] Turn fine-grained-dependencies on-by-default. #29379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2020
Merged

[Incremental] Turn fine-grained-dependencies on-by-default. #29379

merged 1 commit into from
Jan 24, 2020

Conversation

davidungar
Copy link
Contributor

Turn off by passing in -disable-fine-grained-dependencies.

@davidungar
Copy link
Contributor Author

@swift-ci please smoke test

@davidungar
Copy link
Contributor Author

@swift-ci please test

@davidungar
Copy link
Contributor Author

@swift-ci please test windows

@davidungar
Copy link
Contributor Author

@swift-ci please test source compatibility

@davidungar
Copy link
Contributor Author

@swift-ci please test compiler performance

@varungandhi-apple
Copy link
Contributor

Just a random thought (kinda' struck me after reading your PR): do you find it odd that we have the default values for different options duplicated in several places? It does seem a little bit dissatisfying but maybe it is fine. Do you think maybe we should lift out the default values into a separate header in the future or is the status quo better?

@davidungar
Copy link
Contributor Author

@swift-ci please test windows platform

@davidungar
Copy link
Contributor Author

davidungar commented Jan 23, 2020 •
edited
Loading

Just a random thought (kinda' struck me after reading your PR): do you find it odd that we have the default values for different options duplicated in several places? It does seem a little bit dissatisfying but maybe it is fine. Do you think maybe we should lift out the default values into a separate header in the future or is the status quo better?

Thanks for reading it over, and I like your thought. It's not a layering violation, so I will make that change as a separate PR, and land that one first!

@swift-ci
Copy link
Contributor

Summary for master full

Unexpected test results, excluded stats for RxCocoa, SwifterSwift, Base64CoderSwiftUI

Regressions found (see below)

Debug-batch

debug-batch brief

Regressed (1)
name old new delta delta_pct
time.swift-driver.wall 3644.7s 3696.1s 51.4s 1.41% ⛔
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 63,671,521,664,098 64,046,353,966,296 374,832,302,198 0.59%
LLVM.NumLLVMBytesOutput 1,788,031,190 1,788,026,726 -4,464 -0.0%

debug-batch detailed

Regressed (0)
name old new delta delta_pct
Improved (1)
name old new delta delta_pct
AST.NumSourceLinesPerSecond 4,441,876 4,394,372 -47,504 -1.07% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (208)
name old new delta delta_pct
AST.ImportSetCacheHit 1,655,445 1,655,639 194 0.01%
AST.ImportSetCacheMiss 637,233 637,240 7 0.0%
AST.ImportSetFoldHit 315,514 315,507 -7 -0.0%
AST.ImportSetFoldMiss 321,718 321,733 15 0.0%
AST.ModuleShadowCacheHit 2,013 2,013 0 0.0%
AST.ModuleShadowCacheMiss 1,512 1,512 0 0.0%
AST.ModuleVisibilityCacheHit 28,905 28,905 0 0.0%
AST.ModuleVisibilityCacheMiss 6,638 6,638 0 0.0%
AST.NumASTBytesAllocated 54,490,833,624 54,623,317,598 132,483,974 0.24%
AST.NumASTScopeLookups 3,530,641 3,530,600 -41 -0.0%
AST.NumBraceStmtASTScopeExpansions 619,397 619,397 0 0.0%
AST.NumBraceStmtASTScopes 619,397 619,397 0 0.0%
AST.NumDecls 139,869 139,869 0 0.0%
AST.NumDependencies 301,387 301,375 -12 -0.0%
AST.NumInfixOperators 53,695 53,695 0 0.0%
AST.NumIterableTypeBodyASTScopeExpansions 227,933 227,932 -1 -0.0%
AST.NumIterableTypeBodyASTScopes 279,690 279,684 -6 -0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 281,092 281,092 0 0.0%
AST.NumLocalTypeDecls 250 250 0 0.0%
AST.NumModuleLookupClassMember 6,927 6,927 0 0.0%
AST.NumModuleLookupValue 41,414,890 41,421,434 6,544 0.02%
AST.NumObjCMethods 24,240 24,240 0 0.0%
AST.NumPostfixOperators 49 49 0 0.0%
AST.NumPrecedenceGroups 25,840 25,840 0 0.0%
AST.NumPrefixOperators 99 99 0 0.0%
AST.NumReferencedDynamicNames 189 189 0 0.0%
AST.NumReferencedMemberNames 6,310,868 6,310,868 0 0.0%
AST.NumReferencedTopLevelNames 476,279 476,279 0 0.0%
AST.NumSourceBuffers 653,984 653,984 0 0.0%
AST.NumSourceLines 4,718,651 4,718,651 0 0.0%
AST.NumTotalClangImportedEntities 4,828,376 4,832,971 4,595 0.1%
Driver.ChildrenMaxRSS 243,450,554,368 243,413,817,344 -36,737,024 -0.02%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 28,030 28,030 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumDriverPipePolls 114,088 115,050 962 0.84%
Driver.NumDriverPipeReads 105,325 106,260 935 0.89%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.MaxMallocUsage 1,076,228,188,152 1,078,396,030,032 2,167,841,880 0.2%
Frontend.NumInstructionsExecuted 63,671,521,664,098 64,046,353,966,296 374,832,302,198 0.59%
Frontend.NumProcessFailures 0 0 0 0.0%
IRModule.NumIRAliases 196,343 196,343 0 0.0%
IRModule.NumIRBasicBlocks 6,876,623 6,876,623 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 3,372,504 3,372,504 0 0.0%
IRModule.NumIRGlobals 3,666,477 3,666,477 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 86,990,701 86,990,701 0 0.0%
IRModule.NumIRNamedMetaData 135,380 135,380 0 0.0%
IRModule.NumIRValueSymbols 6,383,820 6,383,820 0 0.0%
LLVM.NumLLVMBytesOutput 1,788,031,190 1,788,026,726 -4,464 -0.0%
Parse.NumFunctionsParsed 269,032 269,032 0 0.0%
Parse.NumIterableDeclContextParsed 617,989 617,965 -24 -0.0%
Parse.ParseAbstractFunctionBodyRequest 246,137 246,137 0 0.0%
Parse.ParseMembersRequest 486,127 486,103 -24 -0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 1,701,544 1,701,544 0 0.0%
SILModule.NumSILGenGlobalVariables 53,562 53,562 0 0.0%
SILModule.NumSILGenVtables 18,627 18,627 0 0.0%
SILModule.NumSILGenWitnessTables 72,403 72,403 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 2,520,645 2,520,645 0 0.0%
SILModule.NumSILOptGlobalVariables 55,195 55,195 0 0.0%
SILModule.NumSILOptVtables 31,428 31,428 0 0.0%
SILModule.NumSILOptWitnessTables 169,298 169,298 0 0.0%
Sema.AbstractGenericSignatureRequest 30,630 30,630 0 0.0%
Sema.AccessLevelRequest 11,692,172 11,748,544 56,372 0.48%
Sema.AnyObjectLookupRequest 281 281 0 0.0%
Sema.AreAllStoredPropertiesDefaultInitableRequest 21,027 21,027 0 0.0%
Sema.AttachedFunctionBuilderRequest 1 1 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 538,694 538,694 0 0.0%
Sema.AttachedPropertyWrappersRequest 2,281,542 2,281,543 1 0.0%
Sema.CallerSideDefaultArgExprRequest 78,657 78,657 0 0.0%
Sema.ClassAncestryFlagsRequest 96,510 96,510 0 0.0%
Sema.CollectOverriddenDeclsRequest 7,102,455 7,150,582 48,127 0.68%
Sema.CompareDeclSpecializationRequest 464,141 464,544 403 0.09%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 1 1 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 53,552 53,554 2 0.0%
Sema.DefaultArgumentExprRequest 38,181 38,181 0 0.0%
Sema.DefaultArgumentInitContextRequest 454 454 0 0.0%
Sema.DefaultDefinitionTypeRequest 7,750 7,750 0 0.0%
Sema.DefaultTypeRequest 467,436 467,436 0 0.0%
Sema.DifferentiableAttributeTypeCheckRequest 0 0 0 0.0%
Sema.DynamicallyReplacedDeclRequest 1,013,279 1,013,279 0 0.0%
Sema.EmittedMembersRequest 25,899 25,899 0 0.0%
Sema.EnumRawTypeRequest 21,816 21,816 0 0.0%
Sema.EnumRawValuesRequest 10,526 10,526 0 0.0%
Sema.ExistentialConformsToSelfRequest 14,254 14,273 19 0.13%
Sema.ExistentialTypeSupportedRequest 15,806 15,806 0 0.0%
Sema.ExpandASTScopeRequest 6,429,029 6,429,020 -9 -0.0%
Sema.ExtendedNominalRequest 516,384 516,384 0 0.0%
Sema.ExtendedTypeRequest 75,657 75,656 -1 -0.0%
Sema.FunctionBuilderTypeRequest 1 1 0 0.0%
Sema.FunctionOperatorRequest 51,330 51,330 0 0.0%
Sema.GenericParamListRequest 9,314,343 9,348,876 34,533 0.37%
Sema.GenericSignatureRequest 2,725,482 2,726,794 1,312 0.05%
Sema.GetDestructorRequest 26,389 26,389 0 0.0%
Sema.HasCircularInheritanceRequest 22,567 22,567 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 10,021 10,021 0 0.0%
Sema.HasCircularRawValueRequest 8,958 8,958 0 0.0%
Sema.HasDefaultInitRequest 51,664 51,664 0 0.0%
Sema.HasDynamicMemberLookupAttributeRequest 564,246 564,379 133 0.02%
Sema.HasMemberwiseInitRequest 19,276 19,276 0 0.0%
Sema.HasMissingDesignatedInitializersRequest 24,835 24,835 0 0.0%
Sema.HasUserDefinedDesignatedInitRequest 51,674 51,674 0 0.0%
Sema.InferredGenericSignatureRequest 163,464 163,463 -1 -0.0%
Sema.InheritedDeclsReferencedRequest 5,860,484 5,868,510 8,026 0.14%
Sema.InheritedTypeRequest 277,678 277,710 32 0.01%
Sema.InheritsSuperclassInitializersRequest 26,229 26,229 0 0.0%
Sema.InitKindRequest 91,283 91,283 0 0.0%
Sema.InterfaceTypeRequest 16,542,723 16,598,503 55,780 0.34%
Sema.IsABICompatibleOverrideRequest 135,250 135,250 0 0.0%
Sema.IsAccessorTransparentRequest 309,109 309,109 0 0.0%
Sema.IsCallableNominalTypeRequest 2,078 2,078 0 0.0%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDynamicRequest 1,686,524 1,686,524 0 0.0%
Sema.IsFinalRequest 2,498,198 2,503,324 5,126 0.21%
Sema.IsGetterMutatingRequest 415,764 415,764 0 0.0%
Sema.IsImplicitlyUnwrappedOptionalRequest 2,371,187 2,372,066 879 0.04%
Sema.IsObjCRequest 1,550,368 1,551,020 652 0.04%
Sema.IsSetterMutatingRequest 336,875 336,875 0 0.0%
Sema.IsStaticRequest 2,950,089 2,950,333 244 0.01%
Sema.LazyStoragePropertyRequest 2,197 2,197 0 0.0%
Sema.LookupInModuleRequest 5,671,331 5,676,256 4,925 0.09%
Sema.LookupPrecedenceGroupRequest 175,917 175,917 0 0.0%
Sema.MangleLocalTypeDeclRequest 500 500 0 0.0%
Sema.ModuleQualifiedLookupRequest 2,592,345 2,597,311 4,966 0.19%
Sema.NamedLazyMemberLoadFailureCount 12,909 12,914 5 0.04%
Sema.NamedLazyMemberLoadSuccessCount 11,135,918 11,132,003 -3,915 -0.04%
Sema.NamingPatternRequest 177,320 177,321 1 0.0%
Sema.NeedsNewVTableEntryRequest 661,687 661,687 0 0.0%
Sema.NominalTypeLookupDirectCount 32,580,492 32,603,499 23,007 0.07%
Sema.NumAccessorBodiesSynthesized 189,126 189,126 0 0.0%
Sema.NumAccessorsSynthesized 277,671 277,671 0 0.0%
Sema.NumConformancesDeserialized 8,577,316 8,597,496 20,180 0.24%
Sema.NumConstraintScopes 28,430,323 28,432,765 2,442 0.01%
Sema.NumConstraintsConsideredForEdgeContraction 97,984,931 97,985,458 527 0.0%
Sema.NumCyclicOneWayComponentsCollapsed 0 0 0 0.0%
Sema.NumDeclsDeserialized 65,860,790 66,017,607 156,817 0.24%
Sema.NumDeclsTypechecked 1,412,375 1,412,375 0 0.0%
Sema.NumFunctionsTypechecked 529,348 529,348 0 0.0%
Sema.NumGenericSignatureBuilders 1,278,489 1,279,891 1,402 0.11%
Sema.NumLazyIterableDeclContexts 7,693,388 7,698,828 5,440 0.07%
Sema.NumLazyRequirementSignatures 765,198 765,388 190 0.02%
Sema.NumLazyRequirementSignaturesLoaded 585,741 585,845 104 0.02%
Sema.NumLeafScopes 18,257,689 18,259,777 2,088 0.01%
Sema.NumTypesDeserialized 19,923,562 19,949,212 25,650 0.13%
Sema.NumTypesValidated 1,373,866 1,373,865 -1 -0.0%
Sema.NumUnloadedLazyIterableDeclContexts 4,592,857 4,589,797 -3,060 -0.07%
Sema.OpaqueReadOwnershipRequest 262,720 262,720 0 0.0%
Sema.OpaqueResultTypeRequest 0 0 0 0.0%
Sema.OperatorPrecedenceGroupRequest 724 724 0 0.0%
Sema.OverriddenDeclsRequest 2,337,883 2,344,226 6,343 0.27%
Sema.ParamSpecifierRequest 1,191,025 1,191,023 -2 -0.0%
Sema.PatternBindingEntryRequest 433,287 433,288 1 0.0%
Sema.PatternTypeRequest 554,604 554,605 1 0.0%
Sema.PreCheckFunctionBuilderRequest 0 0 0 0.0%
Sema.PropertyWrapperBackingPropertyInfoRequest 533,672 533,672 0 0.0%
Sema.PropertyWrapperBackingPropertyTypeRequest 538,694 538,694 0 0.0%
Sema.PropertyWrapperMutabilityRequest 610,711 610,711 0 0.0%
Sema.PropertyWrapperTypeInfoRequest 1 1 0 0.0%
Sema.ProtocolRequiresClassRequest 59,127 59,154 27 0.05%
Sema.ProvideDefaultImplForRequest 7,102,455 7,150,582 48,127 0.68%
Sema.QualifiedLookupRequest 6,633,669 6,637,457 3,788 0.06%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RequirementRequest 107,358 107,357 -1 -0.0%
Sema.RequirementSignatureRequest 646,354 646,492 138 0.02%
Sema.RequiresOpaqueAccessorsRequest 1,286,600 1,286,600 0 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 253,474 253,474 0 0.0%
Sema.ResilienceExpansionRequest 1,697,304 1,697,300 -4 -0.0%
Sema.ResolveImplicitMemberRequest 371,585 371,887 302 0.08%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResultTypeRequest 633,407 633,405 -2 -0.0%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SelfAccessKindRequest 782,480 782,591 111 0.01%
Sema.SelfBoundsFromWhereClauseRequest 1,513,912 1,515,287 1,375 0.09%
Sema.SetterAccessLevelRequest 141,939 141,939 0 0.0%
Sema.StorageImplInfoRequest 1,375,572 1,375,572 0 0.0%
Sema.StoredPropertiesAndMissingMembersRequest 29,897 29,897 0 0.0%
Sema.StoredPropertiesRequest 305,343 305,343 0 0.0%
Sema.StructuralTypeRequest 2,078 2,078 0 0.0%
Sema.SuperclassDeclRequest 398,855 398,999 144 0.04%
Sema.SuperclassTypeRequest 52,541 52,541 0 0.0%
Sema.SynthesizeAccessorRequest 277,671 277,671 0 0.0%
Sema.SynthesizeDefaultInitRequest 4,810 4,810 0 0.0%
Sema.SynthesizeMemberwiseInitRequest 3,065 3,065 0 0.0%
Sema.TypeCheckFunctionBodyUntilRequest 529,348 529,348 0 0.0%
Sema.TypeCheckSourceFileRequest 27,076 27,076 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 28,712 28,714 2 0.01%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 8,338 8,338 0 0.0%
Sema.USRGenerationRequest 22,913,241 23,045,073 131,832 0.58%
Sema.UnderlyingTypeDeclsReferencedRequest 314,902 315,214 312 0.1%
Sema.UnderlyingTypeRequest 33,849 33,849 0 0.0%
Sema.UnqualifiedLookupRequest 3,673,584 3,673,543 -41 -0.0%
Sema.ValueWitnessRequest 62,673 62,673 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 49,577,514,205,673 49,574,785,301,617 -2,728,904,056 -0.01%
LLVM.NumLLVMBytesOutput 1,876,760,374 1,876,766,722 6,348 0.0%
time.swift-driver.wall 5517.5s 5507.4s -10.1s -0.18%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (18)
name old new delta delta_pct
AST.NumLoadedModules 30,053 30,053 0 0.0%
AST.NumTotalClangImportedEntities 1,125,537 1,125,537 0 0.0%
IRModule.NumIRBasicBlocks 5,204,758 5,204,758 0 0.0%
IRModule.NumIRFunctions 2,806,447 2,806,447 0 0.0%
IRModule.NumIRGlobals 3,220,753 3,220,753 0 0.0%
IRModule.NumIRInsts 51,765,143 51,765,143 0 0.0%
IRModule.NumIRValueSymbols 5,666,200 5,666,200 0 0.0%
LLVM.NumLLVMBytesOutput 1,876,760,374 1,876,766,722 6,348 0.0%
SILModule.NumSILGenFunctions 1,190,040 1,190,040 0 0.0%
SILModule.NumSILOptFunctions 1,627,077 1,627,077 0 0.0%
Sema.NumConformancesDeserialized 3,474,476 3,474,476 0 0.0%
Sema.NumConstraintScopes 28,108,306 28,108,306 0 0.0%
Sema.NumDeclsDeserialized 10,610,179 10,610,179 0 0.0%
Sema.NumFunctionsTypechecked 532,970 532,970 0 0.0%
Sema.NumGenericSignatureBuilders 280,288 280,288 0 0.0%
Sema.NumLazyIterableDeclContexts 1,314,157 1,314,157 0 0.0%
Sema.NumTypesDeserialized 5,183,171 5,183,171 0 0.0%
Sema.NumTypesValidated 826,979 826,979 0 0.0%

@davidungar davidungar force-pushed the fine-grained-on-by-default branch from 60e9167 to 0852a1b Compare January 23, 2020 23:02
@davidungar
Copy link
Contributor Author

@swift-ci please smoke test

@davidungar
Copy link
Contributor Author

@swift-ci please smoke test os x platform

1 similar comment
@davidungar
Copy link
Contributor Author

@swift-ci please smoke test os x platform

@davidungar
Copy link
Contributor Author

@swift-ci please clean smoke test linux platform

@davidungar
Copy link
Contributor Author

@swift-ci please smoke test linux

@davidungar davidungar merged commit ab99ae2 into master Jan 24, 2020
@davidungar davidungar mentioned this pull request Jun 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidungar @varungandhi-apple @swift-ci