[Diagnostics] Add a basic terminal markdown printer for educational notes #28612
Conversation
|
I'm not sure who has the most context to review markup library changes these days, it looks like it hasn't changed much in the past few years. If anyone could recommend a reviewer I'd appreciate it! |
|
Hi @nkcsgexi , I looked in the code-owners file and saw that you're the swiftMarkup owner. Do you mind taking a look at this PR or recommending a reviewer? |
owenv
force-pushed
the
terminal_md_viewer
branch
from
c94c9fb to
deefec5
Compare
|
@swift-ci please test |
|
@swift-ci please test windows platform |
|
@nkcsgexi friendly ping |
owenv
force-pushed
the
terminal_md_viewer
branch
from
deefec5 to
aad09bd
Compare
|
@swift-ci please test Windows platform |
…otes Currently the printer only supports the subset of markdown used by educational notes. It bolds headers, improves the appearance of lists and horizontal rules, and does basic indenting of blockquotes and code blocks.
owenv
force-pushed
the
terminal_md_viewer
branch
from
aad09bd to
d68089d
Compare
|
@swift-ci please test Windows platform |
|
Windows run passed: https://ci-external.swift.org/view/Pull%20Request/job/swift-PR-windows/580/console @swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
|
@nkcsgexi bump, do you mind looking over these markup changes or recommending a reviewer? |
|
@nathawes could you review this PR please? |
|
@nathawes No problem, thanks for the review! |
|
@swift-ci smoke test and merge |
1 similar comment
|
@swift-ci smoke test and merge |
Currently the printer only supports the subset of markdown used by educational notes. It bolds headers, improves the appearance of lists and horizontal rules, and does basic indenting of block quotes and code blocks.