Skip to content

[build-script] Forward cross-compile host flags to lldb #27910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2019
Merged

[build-script] Forward cross-compile host flags to lldb #27910

merged 1 commit into from
Oct 28, 2019

Conversation

vedantk
Copy link
Contributor

@vedantk vedantk commented Oct 28, 2019

Forward llvm_c_flags to the lldb build to support cross-compilation, as is done for all the other targets.

@vedantk vedantk requested review from JDevlieghere and dcci October 28, 2019 19:27
@vedantk
Copy link
Contributor Author

vedantk commented Oct 28, 2019

@swift-ci smoke test

@vedantk vedantk merged commit 2a05418 into swiftlang:master Oct 28, 2019
@vedantk vedantk deleted the set-host-flags branch October 28, 2019 21:39
dcci
dcci reviewed Oct 28, 2019
View reviewed changes
Copy link
Member

@dcci dcci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcci dcci dcci left review comments

@JDevlieghere JDevlieghere Awaiting requested review from JDevlieghere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vedantk @dcci