[stdlib][Qol] SR-11295 Removing stdlib unnecessary coercions

[LucianoPAlmeida]

This removes unnecessary 'as' same type casts.
Extension of #26710, just separating this in other PR.

cc @xedin

[natecook1000]

Thanks, @LucianoPAlmeida! One small nit, otherwise looks good 👍

[LucianoPAlmeida]

Just updating the initial description
The original diagnostic PR was reverted because of an issue with type variables and contextual types, so it is being re-applied on #27895 :)

[CodaFi]

@swift-ci please smoke test

[LucianoPAlmeida]

Thank's @CodaFi :)
The linux failure seems unrelated

[LucianoPAlmeida]

Although the re-apply of the diagnostic is still in the workings, this is actually not dependent on it. And since it is only very simple removals, I was wondering if we get this in if everything is ok?
Also, can someone with rights kick the CI? if everything is ok of course :)

[CodaFi]

Sure. In the future, though, could you please pull with a rebase so there aren’t intervening merge commits? If this passes, I’ll squash this one out for you.

[CodaFi]

@swift-ci please test

[CodaFi]

@swift-ci please test

[LucianoPAlmeida]

Thank you @CodaFi

In the future, though, could you please pull with a rebase so there aren’t intervening merge commits?

Sure :)

[CodaFi]

⛵️