Skip to content

[sil-ownership] Enable ownership verification on all of the stdlib li… #20029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2018
Merged

[sil-ownership] Enable ownership verification on all of the stdlib li… #20029

merged 1 commit into from
Oct 27, 2018

Conversation

gottesmm
Copy link
Contributor

…braries.

rdar://29791263

@gottesmm
Copy link
Contributor Author

Previously we only did this on the swiftCore. This does it everywhere.

@gottesmm
Copy link
Contributor Author

e.g. in the swift stdlib. It isn't on by default.

@gottesmm
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - b3d549d786831ffb4b84c31dde23d1a2be7b3f27

@gottesmm
Copy link
Contributor Author

The macOS build failed due to closure lifetime fixup messing up ownership in some way. Ownership verification FTW!

@gottesmm
Copy link
Contributor Author

This works now... lets try this again.

@gottesmm gottesmm force-pushed the pr-506348ffb0e1e7faa5c2f1796a9ff5c387319abd branch from b3d549d to b36c6e5 Compare October 26, 2018 19:11
@gottesmm
Copy link
Contributor Author

Some notes:

  1. This only enables sil ownership verification on the overlays by tweaking the cmake files. It does not enable this verification on anything else.
  2. We no longer have any codegen conditional on ownership verification being enabled, so this shouldn't cause any codegen changes from any users of the stdlib.

@gottesmm
Copy link
Contributor Author

@swift-ci test and merge

4 similar comments
@gottesmm
Copy link
Contributor Author

@swift-ci test and merge

@gottesmm
Copy link
Contributor Author

@swift-ci test and merge

@gottesmm
Copy link
Contributor Author

@swift-ci test and merge

@gottesmm
Copy link
Contributor Author

@swift-ci test and merge

@gottesmm
Copy link
Contributor Author

#20084 should fix the os x error.

@gottesmm
Copy link
Contributor Author

@swift-ci test os x platform

1 similar comment
@gottesmm
Copy link
Contributor Author

@swift-ci test os x platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - b36c6e5

@gottesmm
Copy link
Contributor Author

@swift-ci test os x platform

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test os x platform

1 similar comment
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test os x platform

@gottesmm gottesmm merged commit 1982d02 into swiftlang:master Oct 27, 2018
@gottesmm gottesmm deleted the pr-506348ffb0e1e7faa5c2f1796a9ff5c387319abd branch October 27, 2018 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gottesmm @swift-ci