[CodeCompletion] Don't try to resolve generic env for extension in inactive block #20015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
slavapestov
approved these changes
Oct 25, 2018
| @@ -4973,6 +4973,13 @@ void TypeChecker::validateExtension(ExtensionDecl *ext) { | |||
| // Validate the nominal type declaration being extended. | |||
| validateDecl(nominal); | |||
|
|
|||
| // If this is not bound to any decls at this point, this extension is in | |||
There was a problem hiding this comment.
Maybe move this to before the validateDecl() call
…active block Fixes code-completion crash in validateExtension(). When code completion happens, it tries to validate decl contexts. If it's in an extension in inactivec conditional block, the extension haven't been bound to nominal type. That used to cause crash because its GenericParams hasn't been set. rdar://problem/45275782 https://bugs.swift.org/browse/SR-9001
rintaro
force-pushed
the
ide-completion-rdar45275782
branch
from
a747fc0 to
07172f4
Compare
|
@swift-ci Please smoke test |
DougGregor
approved these changes
Oct 26, 2018
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes code-completion crash in
validateExtension().When code completion happens, it tries to validate decl contexts. If it's in an extension in inactive conditional block, the extension haven't been bound to the nominal type. That used to cause crash because its
GenericParamshasn't been set.rdar://problem/45275782
https://bugs.swift.org/browse/SR-9001