Restore -static-executable on Linux. #15183

spevans · 2018-03-12T19:14:07Z

Build libswiftImageInspectionStatic.a from
ImageInspectionELF.cpp and StaticBinaryELF.cpp
Update static-executable-args.lnk and replace
libswiftImageInspectionShared with libswiftImageInspectionStatic.

This fixes -static-executable on Linux to build a static binary (when linked with appropiate libicu .a libs`

compnerd · 2018-03-12T23:13:41Z

Hmm, why not leave this as is, and just modify the swiftrt.o to have a static version which doesn't invoke the register method? That way, this can fully be reincorporated into the runtime, and the driver can make the appropriate choice.

compnerd

See previous comment, I suppose that the notification might work better this way.

spevans · 2018-03-23T19:41:59Z

@compnerd Sorry for the delay in replying, are you suggesting something like create a swiftrt-static.o which doesn't have the call to swift_addNewDSOImage and then modify lib/Driver/ToolChains.cpp to link that version instead, when a static executable is built?

compnerd · 2018-03-28T18:02:53Z

@spevans, yes, effectively that. However, thinking more about this, we can be even more clever about this. On the static builds, you still need to link to the (static) runtime. The static runtime can include the object file, and we can create a reference to it, causing the linker to preserve the object from the runtime itself and avoid having to have the driver push the file into the actual linker invocation.

spevans · 2018-03-28T18:33:36Z

@compnerd In the most recent version I created ImageInspectionStatic-ELF.cpp which is effectively SwiftRT-ELF.cpp with the constructor and swift_addNewDSOImage removed. I also removed linking SwiftRT.o from lib/Driver/Toolchains.cpp for static executables. I think this matches what you are suggesting.

compnerd · 2018-03-31T23:43:14Z

While functionally equivalent, this introduces yet another copy of the table of sections. It is another place where we need to update that list. If we compile the single file with a macro we can get away with a single place for all of ELF, which I think is better.

Addresses the functional change, stylistic changes remain

compnerd · 2018-03-31T23:44:17Z

@swift-ci please test

spevans · 2018-04-03T09:10:45Z

@swift-ci please test

swift-ci · 2018-04-03T09:12:33Z

Build failed
Swift Test OS X Platform
Git Sha - 43f9658447a208e537f511c70a8e8bd5d7e26336

swift-ci · 2018-04-03T09:12:36Z

Build failed
Swift Test Linux Platform
Git Sha - 43f9658447a208e537f511c70a8e8bd5d7e26336

compnerd · 2018-04-04T15:27:37Z

stdlib/public/runtime/SwiftRT-ELF.cpp

+    }
+  }
+}
+


Isn't this just a duplication of the swift_addNewDSOImage? Why not just use that?

compnerd

I think that it might be possible to reduce some duplication of the code which would be better.

spevans · 2018-11-07T23:47:11Z

@swift-ci test linux

swift-ci · 2018-11-08T00:22:19Z

Build failed
Swift Test Linux Platform
Git Sha - b5d0def2dbada20c9a4b188ede1124a4af7815f9

spevans · 2018-11-08T14:25:47Z

@swift-ci test linux

swift-ci · 2018-11-08T16:19:09Z

Build failed
Swift Test Linux Platform
Git Sha - b5d0def2dbada20c9a4b188ede1124a4af7815f9

spevans · 2018-11-09T17:07:39Z

@swift-ci test linux

spevans · 2018-11-10T09:17:55Z

@swift-ci Please smoke test OS X platform

spevans · 2018-11-12T23:22:06Z

@compnerd I know this PR is quite old but I have updated it including a test and removed the duplicate sections I added in SwfitRT-ELF.cpp. Could you take another look at it please?

aemino · 2018-12-22T19:24:49Z

Any updates on this PR?

frol · 2019-04-07T09:12:59Z

I have bumped into this issue and filed a bug: https://bugs.swift.org/browse/SR-10328.

spevans · 2019-04-08T21:25:12Z

@frol Unfortunately this PR still has some issues on Ubuntu18.04, relating to glibc and pthreads so it still needs some more work

jckarter · 2019-04-08T21:40:37Z

While functionally equivalent, this introduces yet another copy of the table of sections. It is another place where we need to update that list. If we compile the single file with a macro we can get away with a single place for all of ELF, which I think is better.

As I think you were alluding to, in a fully-static binary there really isn't any need for a table of sections at all, since we ought to be able to link the runtime directly against the beginnings and ends of the sections from the main program.

miguelangel-dev · 2019-05-29T22:51:16Z

Just a quick question, I was using -static-executable in macox, with sdk iphonesimulator and target x86_64-apple-ios12.2-simulator- it stops to work (I think from Swift 5) and it throws the next error:

llvm error: -static-executable is not supported on darwin

This PR will solve this error?

spevans · 2019-05-29T23:10:56Z

Apple platforms do not support statically linked executables, see https://developer.apple.com/library/content/qa/qa1118/_index.html

- Build libswiftImageInspectionStatic.a from SwiftRT-ELF.cpp and StaticBinaryELF.cpp - Update static-executable-args.lnk and replace libswiftImageInspectionShared with libswiftImageInspectionStatic. - Add driver tests for '-static-executable' on Linux to validate that output binary is statically linked. - Fix linkage to pthreads and SwiftRT-ELF.o in a static executable

- If an address does not fall inside a symbol's region then return the symbol with the smallest gap between then end of the symbol's region and the address.

spevans · 2019-05-31T08:43:31Z

Please test with following PR:

swiftlang/swift-integration-tests#59
@swift-ci test

swift-ci · 2019-05-31T08:46:28Z

Build failed
Swift Test Linux Platform
Git Sha - 1d2ea193d1ed54bd80141200452106d8720699ee

swift-ci · 2019-05-31T08:47:18Z

Build failed
Swift Test OS X Platform
Git Sha - 1d2ea193d1ed54bd80141200452106d8720699ee

spevans · 2019-05-31T08:50:11Z

Please test with following PR:

swiftlang/swift-integration-tests#59
@swift-ci test

swift-ci · 2019-05-31T09:28:52Z

Build failed
Swift Test Linux Platform
Git Sha - c77d3a6

spevans · 2019-05-31T09:29:50Z

Please test with following PR:

swiftlang/swift-integration-tests#59
@swift-ci test linux

CodaFi · 2019-12-02T18:23:27Z

@spevans It's been a while and this has gathered quite a few conflicts. Is this still something you're interested in pursuing?

aemino · 2019-12-02T19:53:06Z

Would restoring the static executable flag for Linux allow statically-linked toolchains on Linux? Because if so, I think that would be incredibly helpful for producing cross-distro compatible Linux toolchains.

spevans · 2019-12-02T23:12:47Z

@CodaFi I'll close this off for now, I need to get --static-stdlib working with Foundation first anyway and this PR had issues on Ubutnu18.04 if I recall (it worked ok on 16.04)

@aemino This PR was for producing statically linked binaries as the output of swiftc not actually building statically linked versions of the compiler itself.

spevans requested a review from compnerd March 12, 2018 19:14

compnerd previously requested changes Mar 19, 2018

View reviewed changes

spevans force-pushed the pr_static_executable_fix branch from 9026cf6 to 176f2ad Compare March 24, 2018 20:35

spevans force-pushed the pr_static_executable_fix branch from 43f9658 to e9774ac Compare April 2, 2018 20:09

compnerd reviewed Apr 4, 2018

View reviewed changes

compnerd mentioned this pull request Apr 4, 2018

Remove swiftImageInspectionShared #15692

Closed

spevans force-pushed the pr_static_executable_fix branch 2 times, most recently from cea1288 to b5d0def Compare November 7, 2018 23:46

spevans force-pushed the pr_static_executable_fix branch from b5d0def to 1d2ea19 Compare November 9, 2018 17:07

spevans added 2 commits May 31, 2019 09:02

StaticBinaryELF: When finding a symbol by address allow a closest match.

c77d3a6

- If an address does not fall inside a symbol's region then return the symbol with the smallest gap between then end of the symbol's region and the address.

spevans force-pushed the pr_static_executable_fix branch from 1d2ea19 to c77d3a6 Compare May 31, 2019 08:30

CodaFi assigned compnerd Nov 18, 2019

spevans closed this Dec 2, 2019

spevans mentioned this pull request Dec 2, 2019

SR-7309: Add tests for -static-executable on Linux swiftlang/swift-integration-tests#59

Closed

This was referenced Nov 4, 2018

[SR-3819] ICU often needs -ldl, even if linked statically #46404

Closed

[SR-7039] can't use -static-stdlib (or -static-executable) with any Dispatch using app swiftlang/swift-corelibs-libdispatch#662

Closed

swift-ci mentioned this pull request Apr 7, 2019

[SR-10328] static-executable hits undefined references on Linux swiftlang/swift-docker#291

Closed

Restore -static-executable on Linux. #15183

Restore -static-executable on Linux. #15183

Uh oh!

Conversation

spevans commented Mar 12, 2018

Uh oh!

compnerd commented Mar 12, 2018

Uh oh!

compnerd left a comment

Choose a reason for hiding this comment

Uh oh!

spevans commented Mar 23, 2018

Uh oh!

compnerd commented Mar 28, 2018

Uh oh!

spevans commented Mar 28, 2018

Uh oh!

compnerd commented Mar 31, 2018

Uh oh!

compnerd commented Mar 31, 2018

Uh oh!

spevans commented Apr 3, 2018

Uh oh!

swift-ci commented Apr 3, 2018

Uh oh!

swift-ci commented Apr 3, 2018

Uh oh!

compnerd Apr 4, 2018

Choose a reason for hiding this comment

Uh oh!

compnerd left a comment

Choose a reason for hiding this comment

Uh oh!

spevans commented Nov 7, 2018

Uh oh!

swift-ci commented Nov 8, 2018

Uh oh!

spevans commented Nov 8, 2018

Uh oh!

swift-ci commented Nov 8, 2018

Uh oh!

spevans commented Nov 9, 2018

Uh oh!

spevans commented Nov 10, 2018

Uh oh!

spevans commented Nov 12, 2018

Uh oh!

aemino commented Dec 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

frol commented Apr 7, 2019

Uh oh!

spevans commented Apr 8, 2019

Uh oh!

jckarter commented Apr 8, 2019

Uh oh!

miguelangel-dev commented May 29, 2019

Uh oh!

spevans commented May 29, 2019

Uh oh!

spevans commented May 31, 2019

Uh oh!

swift-ci commented May 31, 2019

Uh oh!

swift-ci commented May 31, 2019

Uh oh!

spevans commented May 31, 2019

Uh oh!

swift-ci commented May 31, 2019

Uh oh!

spevans commented May 31, 2019

Uh oh!

CodaFi commented Dec 2, 2019

Uh oh!

aemino commented Dec 2, 2019

Uh oh!

spevans commented Dec 2, 2019

Uh oh!

Uh oh!

aemino commented Dec 22, 2018 •

edited

Loading