Android CI: swift-foundation: error: 'nil' is not compatible with expected element type 'UnsafeMutablePointer<CChar>'

[nate-chandler]

Description

The Windows toolchain build is failing while building swift-foundation for Android with

swift-foundation/Sources/FoundationEssentials/FileManager/FileOperations+Enumeration.swift:183:60: error: 'nil' is not compatible with expected element type 'UnsafeMutablePointer<CChar>' (aka 'UnsafeMutablePointer<Int8>')

Reproduction

Expected behavior

No error.

Environment

Windows CI

Additional information

No response

[nate-chandler]

CC @compnerd @finagolfin

[compnerd]

Hah, just filed swiftlang/swift-foundation#1426 for that as well.

[compnerd]

This is in the call to fts_open which is modified via APINotes at https://github.com/swiftlang/swift/blob/main/stdlib/public/Platform/posix_filesystem.apinotes ... the distributed signature in the NDK is incorrect (fixed after I reported it to Google). This sounds like APINotes might not be processed properly?

CC: @artemcm @egorzhdan

[finagolfin]

Could be something specific to the Windows compiler as I cross-compiled the corelibs for Android last week on linux from trunk without issue, but if not that, agree with Saleem that probably some apinotes regression. I'll kick off a fresh trunk build on linux to check, but won't have the results till tomorrow.

[compnerd]

I can't seem to reproduce this locally, I'm going to try again with an updated llvm-project (if it ends up reproducing, it is likely swiftlang/llvm-project@56828f4).

CC: @vsapsai

[finagolfin]

Took longer than I hoped, because of a slow CI and some new failing tests in the compiler validation suite, but I cross-compiled the corelibs from latest trunk yesterday for Android AArch64, x86_64, and armv7 without a problem on linux x86_64. The commits used were 2211d9f for the Swift repo and 49d0143d4ba for LLVM. A full build log is available at the above github CI link, to compare for any differences to the failing Windows build.

[finagolfin]

I compared the log from the last passing Windows toolchain build from two weeks ago to the latest failing one, both install the needed note, Installing: T:/Program Files/Swift/Platforms/Android.platform/Developer/SDKs/Android.sdk/usr/lib/swift/apinotes/posix_filesystem.apinotes.

However, I notice that the failing build uses a different SDK path, T:\5\bin\swiftc.exe -target aarch64-unknown-linux-android ... -sdk "T:/Program Files/Swift/Platforms/Android.platform/Developer/SDKs/AndroidExperimental.sdk": maybe something broke in the last couple weeks on Windows so the apinotes are no longer being copied over properly?