[SR-6264] Unify duplicated code in GlobalPropertyOpt::isVisibleExternally() and FunctionLivenessComputation::isVisibleExternally()

[gparker42]

Previous ID	SR-6264
Radar	None
Original Reporter	@gparker42
Type	Improvement

Additional Detail from JIRA

Votes	0
Component/s	Compiler
Labels	Improvement, IRGen, StarterBug
Assignee	None
Priority	Medium

md5: 7fe2948a0ff34a9d22f375125e2fe476

Issue Description:

Functions GlobalPropertyOpt::isVisibleExternally() and FunctionLivenessComputation::isVisibleExternally() have duplicated code that checks whether a declaration may be externally used based on its access level. This duplication should be fixed.

Possible solution: add a function to class ValueDecl to do the work, and call it from both places.

[gparker42]

isAssignableExternally() in LetPropertiesOpt.cpp is another duplication.

[swift-ci]

Comment by Dave Weston (JIRA)

ronaldsmartin (JIRA User), are you still working on this issue?

[swift-ci]

Comment by Dave Weston (JIRA)

In progress PR here: #13720

[belkadan]

Resetting assignee for all Starter Bugs that haven't been modified since 2018. If someone wants to pick up dtweston (JIRA User)'s PR they're welcome to!