[IDE] Set constraint system options from solveForCodeCompletion in applyResultBuilderBodyTransform when solving for code completion

Author: ahoppen

lib/Sema/BuilderTransform.cpp

@@ -1006,6 +1006,9 @@ Optional<BraceStmt *> TypeChecker::applyResultBuilderBodyTransform(
   // Solve the constraint system.
   if (cs.getASTContext().CompletionCallback) {
     SmallVector<Solution, 4> solutions;
+    cs.Options |= ConstraintSystemFlags::AllowFixes;
+    cs.Options |= ConstraintSystemFlags::SuppressDiagnostics;
+    cs.Options |= ConstraintSystemFlags::ForCodeCompletion;
     cs.solveForCodeCompletion(solutions);
 
     CompletionContextFinder analyzer(func, func->getDeclContext());

test/IDE/complete_call_arg.swift

@@ -1511,7 +1511,7 @@ struct AmbiguousCallInResultBuilder {
   func ttroke(_ content: Int, lineWidth: Int = 1) -> Int { 42 }
 
   @MyResultBuilder var body: Int {
-    self.ttroke(1, #^AMBIGUOUS_IN_RESULT_BUILDER?xfail=TODO^#)
+    self.ttroke(1, #^AMBIGUOUS_IN_RESULT_BUILDER^#)
 // AMBIGUOUS_IN_RESULT_BUILDER: Begin completions, 2 items
 // AMBIGUOUS_IN_RESULT_BUILDER-DAG: Pattern/Local/Flair[ArgLabels]:     {#style: String#}[#String#];
 // AMBIGUOUS_IN_RESULT_BUILDER-DAG: Pattern/Local/Flair[ArgLabels]:     {#lineWidth: Int#}[#Int#];

test/IDE/complete_in_result_builder.swift

@@ -388,3 +388,24 @@ func testCompleteIfLetInResultBuilder() {
     // IF_LET_IN_RESULT_BUILDER: End completions
   }
 }
+
+func testOverloadedCallArgs() {
+  func overloaded(single: Int) -> Int {}
+  func overloaded(_ first: Int, second: Int) -> Int {}
+
+  @resultBuilder struct ViewBuilder {
+    static func buildBlock(_ content: Int) -> Int { content }
+  }
+
+  struct Test {
+    @ViewBuilder var body: Int {
+      overloaded(#^OVERLOADED_CALL_ARG^#, second: 1)
+      // OVERLOADED_CALL_ARG: Begin completions
+      // OVERLOADED_CALL_ARG-DAG: Decl[FreeFunction]/Local/Flair[ArgLabels]/TypeRelation[Convertible]: ['(']{#single: Int#}[')'][#Int#];
+      // OVERLOADED_CALL_ARG-DAG: Decl[FreeFunction]/Local/Flair[ArgLabels]/TypeRelation[Convertible]: ['(']{#(first): Int#}, {#second: Int#}[')'][#Int#];
+      // OVERLOADED_CALL_ARG-DAG: Literal[Integer]/None/TypeRelation[Convertible]: 0[#Int#];
+      // OVERLOADED_CALL_ARG: End completions
+    }
+  }
+
+}