Add a return type for exit tests. #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a new structure, `ExitTest.Result`, that is returned from a call to `#expect(exitsWith:)` or `#require(exitsWith:)`. It currently contains the actual exit condition of the test (which should equal the expected exit condition on success) but in the future we can add additional properties such as the standard output and standard error streams.
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
… failure, as much as is possible)
|
@swift-ci test |
stmontgomery
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new structure,
ExitTest.Result, that is returned from a call to#expect(exitsWith:)or#require(exitsWith:). It currently contains the actual exit condition of the test (which should equal the expected exit condition on success) but in the future we can add additional properties such as the standard output and standard error streams.Checklist: