Skip to content

Remove TemporaryGettingStarted.md. #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2024
Merged

Remove TemporaryGettingStarted.md. #706

merged 3 commits into from
Sep 18, 2024

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Sep 17, 2024 •
edited
Loading

This PR removes TemporaryGettingStarted.md and references to it, as well as references in documentation to Xcode 16 betas. Now that Swift 6 has shipped, these instructions are no longer needed.

The section about testing on WASI has been moved to Documentation/WASI.md.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Remove TemporaryGettingStarted.md.
fecdc3a 
This PR removes TemporaryGettingStarted.md and references to it, as well as
references in documentation to Xcode 16 betas. Now that Swift 6 has shipped,
these instructions are no longer needed.

The section about testing on WASI has been moved to Documentation/WASI.md.
@grynspan grynspan added documentation 📚 Improvements or additions to documentation enhancement New feature or request labels Sep 17, 2024
@grynspan grynspan added this to the Swift 6.1 milestone Sep 17, 2024
@grynspan grynspan self-assigned this Sep 17, 2024
@grynspan
Copy link
Contributor Author

@swift-ci test

stmontgomery
stmontgomery reviewed Sep 17, 2024
View reviewed changes
stmontgomery
stmontgomery reviewed Sep 17, 2024
View reviewed changes
iamleeg
iamleeg approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@iamleeg iamleeg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't got anything to say about WASM because I don't really know it but I think you've handled removing the getting started guide fine. I made one suggestion but it's a nit and I don't mind if you handle it differently or not at all.

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan merged commit 1a96c0c into main Sep 18, 2024
3 checks passed
@grynspan grynspan deleted the jgrynspan/remove-temporary-getting-started branch September 18, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@iamleeg iamleeg iamleeg approved these changes

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
documentation 📚 Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
Swift 6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@grynspan @stmontgomery @iamleeg