Don't emit JSON blobs for test cases if a test function isn't parameterized. #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erized. Internally, Swift Testing models non-parameterized test functions as parameterized over a single input, `()`. This is a very useful abstraction internally, but when it comes to the JSON output for parameterized tests, it can be confusing or surprising to see information about a test case that was synthesized by the library. This PR suppresses events and metadata for the single test case of a non-parameterized test function.
grynspan
added
bug
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
|
Have you thought about what kind/layering of test coverage we should have for this code? |
We already technically have tests that cover this code, it's just never been a failure for extra data to be present. I intend to add some additional test coverage once the JSON format is finalized per #479. |
briancroom
approved these changes
Jun 14, 2024
grynspan
deleted the
jgrynspan/no-test-case-events-in-json-stream-unless-parameterized
branch
plemarquand
added a commit
to plemarquand/vscode-swift
that referenced
this pull request
Jun 14, 2024
swiftlang/swift-testing#482 removes the `_testCase` field if the test isn't parameterized. The code that recorded issues relied on this being present. If the issue for a parameterized test case then just extract the test from the testID.
plemarquand
added a commit
to swiftlang/vscode-swift
that referenced
this pull request
Jun 14, 2024
…#897) swiftlang/swift-testing#482 removes the `_testCase` field if the test isn't parameterized. The code that recorded issues relied on this being present. If the issue for a parameterized test case then just extract the test from the testID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally, Swift Testing models non-parameterized test functions as parameterized over a single input,
(). This is a very useful abstraction internally, but when it comes to the JSON output for parameterized tests, it can be confusing or surprising to see information about a test case that was synthesized by the library.This PR suppresses events and metadata for the single test case of a non-parameterized test function.
Checklist: