Add partial WASI/Wasm support. #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows building using the SwiftWasm toolchain from https://swiftwasm.org. As of right now, macro plugins do not build correctly for WASM, so swift-testing is not usable, but it is buildable! ## Testing A workaround is provided on the [jgrynspan/wasi-workaround](https://github.com/apple/swift-testing/tree/jgrynspan/wasi-workaround) branch in order to facilitate testing. Check out that branch, then set the environment variable `SWT_COMPILER_PLUGIN_ENABLED` to `0` when building: ```sh SWT_COMPILER_PLUGIN_ENABLED=0 swift build --triple wasm32-unknown-wasi ``` The macros target should build except for its main function (which will emit a warning about being unsupported) as should the primary library target. It is not possible to build the testing library's tests yet.
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
|
@swift-ci please test |
|
Neat! |
briancroom
approved these changes
Mar 18, 2024
grynspan
commented
Mar 18, 2024
| @@ -140,7 +140,7 @@ struct FileHandle: ~Copyable, Sendable { | |||
| let fd: CInt = -1 | |||
| #endif | |||
|
|
|||
| if fd >= 0 { | |||
| if Bool(fd >= 0) { | |||
There was a problem hiding this comment.
This file doesn't build for WASI, however there's a dead-code warning here on platforms where fileno() isn't defined which is redundant in the face of our explicit warning, so this change silences it.
|
Holding until Yuta can take a look (it's 3AM in Tokyo so it may be a few minutes. 😄) |
grynspan
changed the title
|
This PR does not resolve #228 in its entirety, but it's a step toward it. |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows building using the SwiftWasm toolchain from https://swiftwasm.org. As of right now, macro plugins do not build correctly for Wasm, so swift-testing is not usable, but it is buildable!
Testing
A workaround is provided on the jgrynspan/wasi-workaround branch in order to facilitate testing. Check out that branch, then set the environment variable
SWT_COMPILER_PLUGIN_ENABLEDto0when building:The macros target should build except for its main function (which will emit a warning about being unsupported) as should the primary library target. It is not possible to build the testing library's tests yet.
Checklist: