Skip to content

Add CustomStringConvertible conformance to ExitTest.Condition and StatusAtExit. #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2025

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Apr 11, 2025

This PR adds CustomStringConvertible conformance to these data/value types so that they are presented reasonably in expectation failure messages or when printed.

Strictly speaking, API changes should go through a review, but there's not really anything to review here, so with the consent of the Testing Workgroup we can amend the exit tests proposal to retroactively include these conformances.

See also: swiftlang/swift-evolution#2789

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

… `StatusAtExit`.

This PR adds `CustomStringConvertible` conformance to these data/value types so
that they are presented reasonably in expectation failure messages or when
printed.

Strictly speaking, API changes should go through a review, but there's not
really anything to review here, so with the consent of the Testing Workgroup we
can amend the exit tests proposal to retroactively include these conformances.
@grynspan grynspan added enhancement New feature or request public-api Affects public API exit-tests ☠️ Work related to exit tests labels Apr 11, 2025
@grynspan grynspan added this to the Swift 6.x milestone Apr 11, 2025
@grynspan grynspan self-assigned this Apr 11, 2025
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan merged commit 55f82ed into main Apr 12, 2025
3 checks passed
@grynspan grynspan deleted the jgrynspan/exit-test-status-string-conformance branch April 12, 2025 13:55
@stmontgomery stmontgomery modified the milestones: Swift 6.x, Swift 6.2 Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exit-tests ☠️ Work related to exit tests public-api Affects public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants