Change Attachment.attach() to Attachment.record() and Attachable.withUnsafeBufferPointer() to Attachable.withUnsafeBytes().
#1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….withUnsafeBufferPointer()` to `Attachable.withUnsafeBytes()`. This PR updates the `attach()` function to make it static on `Attachment` and renames it `record()`, per the discussion [here](https://forums.swift.org/t/pitch-attachments/78072). It also renames `Attachable.withUnsafeBufferPointer()` to `Attachable.withUnsafeBytes()` to more closely match the convention used by the standard library for raw buffers. Finally, it removes the conditional dependence on the experimental language feature "SuppressedAssociatedTypes" in `AttachableContainer`.
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
younata
reviewed
Mar 20, 2025
stmontgomery
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
attach()function to make it static onAttachmentand renames itrecord(), per the discussion here.It also renames
Attachable.withUnsafeBufferPointer()toAttachable.withUnsafeBytes()to more closely match the convention used by the standard library for raw buffers.Finally, it removes the conditional dependence on the experimental language feature "SuppressedAssociatedTypes" in
AttachableContainer.Checklist: