Adjust a timing-sensitive TimeLimitTrait test to avoid flakiness in CI #1029
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the
TimeLimitTraitTests.cancelledTestExitsEarly()
test function to make it less sensitive to running on resource-constrained CI systems.Motivation:
Recently on a few PRs I have seen flaky results from this test which are unrelated to my work. They typically show up as console output such as:
This indicates the test is just a little too sensitive to specific timing.
Modifications:
Checklist: