Skip to content

[SwiftLexicalLookup][GSoC] Add a DocC article with description of SwiftLexicalLookup. #2812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

MAJKFL
Copy link
Contributor

@MAJKFL MAJKFL commented Aug 21, 2024

This PR includes a DocC article with high-level description of SwiftLexicalLookup. We thought with @DougGregor it would be great to include it with the final GSoC submission.


## Overview

> Important:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double-check that this works but I think docc supports [!IMPORTANT], which would add some color here

Suggested change
> Important:
> [!IMPORTANT]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly it doesn't seem to work. It just creates a plain note and embeds [!IMPORTANT] in the rest of the text.
Zrzut ekranu 2024-08-21 o 19 00 51
I've also tried [!IMPORTANT]:, **Important:** and **Important**:, but haven't had much luck with them either.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I made it inline.

@MAJKFL MAJKFL requested a review from ahoppen August 21, 2024 17:05
@DougGregor
Copy link
Member

@swift-ci please test

@MAJKFL
Copy link
Contributor Author

MAJKFL commented Aug 22, 2024

Also, the CI failed for macOS in a bunch of tests

Failed Tests (9):
  Swift(macosx-x86_64) :: ModuleInterface/features.swift
  Swift(macosx-x86_64) :: Parse/ConditionalCompilation/compiler.swift
  Swift(macosx-x86_64) :: Parse/ConditionalCompilation/language_version_explicit.swift
  Swift(macosx-x86_64) :: Parse/ConditionalCompilation/sequence_version.swift
  Swift(macosx-x86_64) :: Parse/features.swift
  Swift(macosx-x86_64) :: SILGen/specialize_attr.swift
  Swift(macosx-x86_64) :: SILOptimizer/pre_specialize-macos.swift
  Swift(macosx-x86_64) :: SILOptimizer/pre_specialize.swift
  Swift(macosx-x86_64) :: SILOptimizer/pre_specialize_layouts.swift

They don't seem to be related much with this PR though. Is it possible I forgot to add something important here with the documentation?

@DougGregor
Copy link
Member

@swift-ci please test

@DougGregor
Copy link
Member

@swift-ci please test Windows

@DougGregor DougGregor merged commit e674d66 into swiftlang:main Aug 27, 2024
3 checks passed
@MAJKFL MAJKFL deleted the swiftLexicalLookup-docc branch October 16, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants