Skip to content

Specify platform when building Docker images #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Specify platform when building Docker images #39

merged 2 commits into from
Nov 3, 2023

Conversation

gwynne
Copy link
Contributor

@gwynne gwynne commented Nov 3, 2023

Without this, cross-compiling between a host and target with different CPU architectures when copying from Docker fails due to pulling the wrong Docker image.

@gwynne gwynne requested a review from MaxDesiatov as a code owner November 3, 2023 04:30
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

@MaxDesiatov
Copy link
Contributor

@swift-ci test

@MaxDesiatov
Copy link
Contributor

@swift-ci test

1 similar comment
@MaxDesiatov
Copy link
Contributor

@swift-ci test

@MaxDesiatov MaxDesiatov self-assigned this Nov 3, 2023
@MaxDesiatov
Copy link
Contributor

@swift-ci test Ubuntu 22.04 (Swift 5.9)

@MaxDesiatov
Copy link
Contributor

@swift-ci test

@MaxDesiatov MaxDesiatov merged commit 7e57543 into swiftlang:main Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants