Enable complete concurrency checking, fix warnings #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should enable complete concurrency checking by default, as it already uncovered an issue with `LocalSwiftSDKGenerator` sharing `self` with mutable properties (`var downloadArtifacts`) across different tasks.
|
@swift-ci test |
kateinoigakukun
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should enable complete concurrency checking by default, as it already uncovered an issue with
LocalSwiftSDKGeneratorsharingselfwith mutable properties (var downloadArtifacts) across different tasks.The solution was to make
SwiftSDKGeneratoran actor to isolate direct access to that property and to prevent race conditions.The only remaining few warnings on
throttlewill hopefully go away when https://forums.swift.org/t/pitch-region-based-isolation/67888/8 lands.