Skip to content

Use linuxDistributionVersion if specified otherwise use default version for linuxDistributionName #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2023
Merged

Use linuxDistributionVersion if specified otherwise use default version for linuxDistributionName #25

merged 1 commit into from
Oct 10, 2023

Conversation

rimim
Copy link
Contributor

@rimim rimim commented Oct 10, 2023 •
edited by MaxDesiatov
Loading

Command line argument --linux-distribution-version was ignored and a default version was always used for the specified --linux-distribution-name.

@rimim rimim requested a review from MaxDesiatov as a code owner October 10, 2023 15:57
MaxDesiatov
MaxDesiatov approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@MaxDesiatov MaxDesiatov added the bug Something isn't working label Oct 10, 2023
@MaxDesiatov
Copy link
Contributor

@swift-ci test

@MaxDesiatov MaxDesiatov merged commit cc75a0b into swiftlang:main Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rimim @MaxDesiatov