Remove redundant checkum validation

Author: MaxDesiatov

Sources/SwiftSDKGenerator/Artifacts/DownloadableArtifacts.swift

@@ -46,67 +46,11 @@ enum ArtifactOS: Hashable {
 
 typealias CPUMapping = [Triple.CPU: String]
 
-/// SHA256 hashes of binary LLVM artifacts known to the generator.
-private let knownLLVMBinariesVersions: [ArtifactOS: [String: CPUMapping]] = [
-  .macOS: [
-    "15.0.7": [
-      Triple.CPU.arm64: "867c6afd41158c132ef05a8f1ddaecf476a26b91c85def8e124414f9a9ba188d",
-    ],
-    "16.0.0": [
-      Triple.CPU.arm64: "2041587b90626a4a87f0de14a5842c14c6c3374f42c8ed12726ef017416409d9",
-    ],
-    "16.0.1": [
-      Triple.CPU.arm64: "cb487fa991f047dc79ae36430cbb9ef14621c1262075373955b1d97215c75879",
-    ],
-    "16.0.4": [
-      Triple.CPU.arm64: "429b8061d620108fee636313df55a0602ea0d14458c6d3873989e6b130a074bd",
-    ],
-    "16.0.5": [
-      Triple.CPU.arm64: "1aed0787417dd915f0101503ce1d2719c8820a2c92d4a517bfc4044f72035bcc",
-    ],
-  ],
-]
-
-/// SHA256 hashes of binary Swift artifacts known to the generator.
-private let knownSwiftBinariesVersions: [ArtifactOS: [String: CPUMapping]] = [
-  .linux(.ubuntu(.jammy)): [
-    "5.7.3-RELEASE": [
-      .arm64: "75003d5a995292ae3f858b767fbb89bc3edee99488f4574468a0e44341aec55b",
-    ],
-    "5.8-RELEASE": [
-      .arm64: "12ea2df36f9af0aefa74f0989009683600978f62223e7dd73b627c90c7fe9273",
-    ],
-    "5.9-RELEASE": [
-      .arm64: "30b289e02f7e03c380744ea97fdf0e96985dff504b0f09de23e098fdaf6513f3",
-      .x86_64: "bca015e9d727ca39385d7e5b5399f46302d54a02218d40d1c3063662ffc6b42f",
-    ],
-  ],
-  .macOS: [
-    "5.7.3-RELEASE": [
-      .arm64: "ba3516845eb8f4469a8bb06a273687f05791187324a3843996af32a73a2a687d",
-      .x86_64: "ba3516845eb8f4469a8bb06a273687f05791187324a3843996af32a73a2a687d",
-    ],
-    "5.8-RELEASE": [
-      .arm64: "9b6cc56993652ca222c86a2d6b7b66abbd50bb92cc526efc2b23d47d40002097",
-      .x86_64: "9b6cc56993652ca222c86a2d6b7b66abbd50bb92cc526efc2b23d47d40002097",
-    ],
-    "5.9-RELEASE": [
-      .arm64: "3cf7a4b2f3efcfcb4fef42b6588a7b1c54f7b0f2d0a479f41c3e1620b045f48e",
-      .x86_64: "3cf7a4b2f3efcfcb4fef42b6588a7b1c54f7b0f2d0a479f41c3e1620b045f48e",
-    ],
-  ],
-]
-
-private let knownLLVMSourcesVersions: [String: String] = [
-  "16.0.5": "37f540124b9cfd4680666e649f557077f9937c9178489cea285a672e714b2863",
-]
-
 struct DownloadableArtifacts: Sendable {
   @CacheKey
   struct Item: Sendable {
     let remoteURL: URL
     var localPath: FilePath
-    let checksum: String?
     let isPrebuilt: Bool
   }
 
@@ -145,7 +89,6 @@ struct DownloadableArtifacts: Sendable {
       ),
       localPath: paths.artifactsCachePath
         .appending("host_swift_\(versions.swiftVersion)_\(hostTriple).pkg"),
-      checksum: knownSwiftBinariesVersions[hostArtifactsOS]?[versions.swiftVersion]?[hostTriple.cpu],
       isPrebuilt: true
     )
 
@@ -161,7 +104,6 @@ struct DownloadableArtifacts: Sendable {
       )!,
       localPath: paths.artifactsCachePath
         .appending("host_llvm_\(versions.lldVersion)_\(hostTriple).tar.xz"),
-      checksum: knownLLVMBinariesVersions[hostArtifactsOS]?[versions.lldVersion]?[hostTriple.cpu],
       isPrebuilt: true
     )
 
@@ -170,7 +112,6 @@ struct DownloadableArtifacts: Sendable {
       remoteURL: versions.swiftDownloadURL(),
       localPath: paths.artifactsCachePath
         .appending("target_swift_\(versions.swiftVersion)_\(targetTriple).tar.gz"),
-      checksum: knownSwiftBinariesVersions[targetArtifactsOS]?[versions.swiftVersion]?[targetTriple.cpu],
       isPrebuilt: true
     )
 
@@ -190,7 +131,6 @@ struct DownloadableArtifacts: Sendable {
       )!,
       localPath: self.paths.artifactsCachePath
         .appending("llvm_\(self.versions.lldVersion).src.tar.xz"),
-      checksum: knownLLVMSourcesVersions[self.versions.lldVersion],
       isPrebuilt: false
     )
   }

Sources/SwiftSDKGenerator/Generator/SwiftSDKGenerator+Entrypoint.swift

@@ -26,8 +26,8 @@ public extension Triple.CPU {
   }
 }
 
-extension SwiftSDKGenerator {
-  public func generateBundle(shouldGenerateFromScratch: Bool) async throws {
+public extension SwiftSDKGenerator {
+  func generateBundle(shouldGenerateFromScratch: Bool) async throws {
     var configuration = HTTPClient.Configuration(redirectConfiguration: .follow(max: 5, allowCycles: false))
     // Workaround an issue with github.com returning 400 instead of 404 status to HEAD requests from AHC.
     configuration.httpVersion = .http1Only
@@ -49,9 +49,7 @@ extension SwiftSDKGenerator {
     try createDirectoryIfNeeded(at: pathsConfiguration.sdkDirPath)
     try createDirectoryIfNeeded(at: pathsConfiguration.toolchainDirPath)
 
-    if try await !self.isCacheValid {
-      try await self.downloadArtifacts(client)
-    }
+    try await self.downloadArtifacts(client)
 
     if !shouldUseDocker {
       guard case let .ubuntu(version) = versionsConfiguration.linuxDistribution else {
@@ -102,35 +100,6 @@ extension SwiftSDKGenerator {
       """
     )
   }
-
-  /// Check whether cached downloads for required `DownloadArtifacts.Item` values can be reused instead of downloading
-  /// them each time the generator is running.
-  /// - Returns: `true` if artifacts are valid, `false` otherwise.
-  private var isCacheValid: Bool {
-    get async throws {
-      logGenerationStep("Checking packages cache...")
-
-      guard downloadableArtifacts.allItems.map(\.localPath).allSatisfy(doesFileExist(at:)) else {
-        return false
-      }
-
-      return try await withThrowingTaskGroup(of: Bool.self) { taskGroup in
-        for artifact in downloadableArtifacts.allItems {
-          taskGroup.addTask {
-            try await Self.isChecksumValid(artifact: artifact, isVerbose: self.isVerbose)
-          }
-        }
-
-        for try await isValid in taskGroup {
-          guard isValid else {
-            return false
-          }
-        }
-
-        return true
-      }
-    }
-  }
 }
 
 func logGenerationStep(_ message: String) {

Sources/SwiftSDKGenerator/Generator/SwiftSDKGenerator.swift

@@ -136,24 +136,6 @@ public actor SwiftSDKGenerator {
     #endif
   }
 
-  static func isChecksumValid(artifact: DownloadableArtifacts.Item, isVerbose: Bool) async throws -> Bool {
-    guard let expectedChecksum = artifact.checksum else { return false }
-
-    let computedChecksum = try await String(
-      Shell.readStdout("openssl dgst -sha256 \(artifact.localPath)", shouldLogCommands: isVerbose)
-        .split(separator: "= ")[1]
-        // drop the trailing newline
-        .dropLast()
-    )
-
-    guard computedChecksum == expectedChecksum else {
-      print("SHA256 digest of file at `\(artifact.localPath)` does not match expected value: \(expectedChecksum)")
-      return false
-    }
-
-    return true
-  }
-
   private func buildDockerImage(name: String, dockerfileDirectory: FilePath) async throws {
     try await Shell.run(
       "\(Self.dockerCommand) build . -t \(name)",