Add a helper tool for swift-testing #7771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
bnbarham,
MaxDesiatov,
jakepetroules and
francescomikulis
as code owners
xedin
force-pushed
the
install-testing-helper
branch
from
5700fa0 to
83391e7
Compare
bnbarham
reviewed
Jul 13, 2024
grynspan
reviewed
Jul 13, 2024
grynspan
reviewed
Jul 13, 2024
grynspan
reviewed
Jul 13, 2024
grynspan
reviewed
Jul 13, 2024
Package.swift
Outdated
| .executableTarget( | ||
| name: "swiftpm-testing-helper", | ||
| dependencies: ["Commands"], | ||
| exclude: ["CMakeLists.txt"] |
There was a problem hiding this comment.
We still need to teach CMake about this executable, right?
There was a problem hiding this comment.
I had that originally but it's not part of the regular build and bootstrap is using freshly build swiftpm so I think we are good.
xedin
force-pushed
the
install-testing-helper
branch
from
83391e7 to
d38e575
Compare
|
@swift-ci please test |
xedin
force-pushed
the
install-testing-helper
branch
from
d38e575 to
5a30490
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
xedin
force-pushed
the
install-testing-helper
branch
from
5a30490 to
541f70d
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
grynspan
reviewed
Jul 15, 2024
grynspan
reviewed
Jul 15, 2024
xedin
force-pushed
the
install-testing-helper
branch
from
541f70d to
2675573
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
grynspan
approved these changes
Jul 15, 2024
bnbarham
approved these changes
Jul 15, 2024
Since the xctest and swift-testing are being unified into one product we need an additional tool (just like `swiftpm-xctest-helper`) to load and run swift-testing tests from the unified bundle.
xedin
force-pushed
the
install-testing-helper
branch
from
2675573 to
6021057
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
1 similar comment
|
@swift-ci please test Windows platform |
xedin
added a commit
that referenced
this pull request
Jul 15, 2024
The `swiftpm-testing-helper` itself is merged separately by #7771
grynspan
pushed a commit
that referenced
this pull request
Jul 15, 2024
The `swiftpm-testing-helper` itself is merged separately by #7771
grynspan
pushed a commit
that referenced
this pull request
Jul 15, 2024
The `swiftpm-testing-helper` itself is merged separately by #7771
xedin
added a commit
that referenced
this pull request
Jul 16, 2024
- Explanation: Since the xctest and swift-testing are being unified into one product we need an additional tool (just like `swiftpm-xctest-helper`) to load and run swift-testing tests from the unified bundle. - Main Branch PR: #7771 - Risk: Low - Reviewed By: @bnbarham @grynspan - Testing: This change doesn't impact SwiftPM functionality *yet*, it's merely hosting the executable. (cherry picked from commit 6021057)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Since the xctest and swift-testing are being unified into one product we need an additional tool (just like
swiftpm-xctest-helper) to load and run swift-testing tests from the unified bundle.Modifications:
swiftpm-testing-helperthat accepts a bundle path as an argument.Result:
swift-testing tests can be run from the unified bundle.