Declare Data.period property is a way compatitible with + operator
#6149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cannot use `extension Data` if `period` is going to be used with `+` operator via leading-dot syntax, for example: `Data(...) + .period` because `+` is declared as `(Self, Other) -> Self` where `Other: RangeReplaceableCollection, Other.Element == Self.Element` which means that `.period` couldn't get `Data` inferred from the first argument.
|
Using this PR to test swiftlang/swift#63585 |
|
@swift-ci please test |
|
@swift-ci smoke test |
xedin
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
|
@tomerd Would you mind if I landed this if there are no failures? Our performance testing suite cannot handle cross repository testing. |
|
@xedin 👍 |
tomerd
approved these changes
Feb 14, 2023
neonichu
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot use
extension Dataifperiodis going to be used with+operator via leading-dot syntax, for example:Data(...) + .periodbecause+is declared as(Self, Other) -> SelfwhereOther: RangeReplaceableCollection, Other.Element == Self.Elementwhich means that.periodcouldn't getDatainferred from the first argument.