SR-7039: Add test for -static-stdlib when using Dispatch #58
Conversation
|
Test requires swiftlang/swift#25085 and swiftlang/swift-corelibs-libdispatch#489 |
spevans
force-pushed
the
pr_sr_7039_static_stdlib_test
branch
2 times, most recently
from
0ca25f7 to
e1bbc3e
Compare
|
@swift-ci test |
|
@weissi Could you test and merge this please I don't have commit access to this repo, thanks |
|
@kevints is doing the release management for this release |
|
@swift-ci test |
| REQUIRES: platform=Linux | ||
| RUN: rm -rf %t | ||
| RUN: mkdir -p %t | ||
| RUN: %{swiftc} -static-stdlib %S/dispatch_test.swift -lDispatchStubs -lbsd -o %t/dispatch_test |
There was a problem hiding this comment.
-lDispatchStubs being necessary seems very suspect to me. Shouldn't that be handled by Dispatch itself?
There was a problem hiding this comment.
@kevints is doing the release management for this release
This is targeted at master, so this should be reviewed by code owners instead.
There was a problem hiding this comment.
For that matter -lbsd seems suspect. Is the problem a missing modulemap for libbsd?
There was a problem hiding this comment.
libdispatch.a is an archive library so wont auto link libswiftDispatch.a and libDispatchStubs.a hence being explicitly listed.
-lbsd was needed the last time I tested this to provide strlcpy and getprogname however it looks like they are now included as shims in the dispatch source tree so I have removed -lbsd from the test.
@kevints @jrose-apple Could someone please re-CI test this PR, thanks
There was a problem hiding this comment.
Yeah, @kevints reminded me about what we can and can't do with static libraries. I just wasn't thinking.
spevans
force-pushed
the
pr_sr_7039_static_stdlib_test
branch
from
e1bbc3e to
638cfa6
Compare
|
@swift-ci Please test |
|
@swift-ci test |
spevans
force-pushed
the
pr_sr_7039_static_stdlib_test
branch
from
638cfa6 to
67172d8
Compare
|
@shahmishal Is it possible to run tests in this repo? |
|
We don't support PR testing on this repository yet. |
|
I tested this PR using another one swiftlang/swift-corelibs-foundation#2335 and the log is here: https://ci.swift.org/job/swift-corelibs-foundation-PR-Linux/3441/consoleFull Looks like it passed ok so I think its ok to merge now. |
No description provided.