Skip to content

WiX: version the installations of the toolchain, devtools, runtime #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

compnerd
Copy link
Member

These packages are meant to be parallel installed with different releases except in the case of development releases. Wire up the package version information into the path.

@compnerd
Copy link
Member Author

This doesn't version XCTest yet, but we do not have a package version for XCTest it seems, so its unclear what is the best way to version XCTest.

Copy link
Contributor

@tristanlabelle tristanlabelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the wxi!

These packages are meant to be parallel installed with different
releases except in the case of development releases.  Wire up the
package version information into the path.
Copy link
Contributor

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified base installer still works. LGTM

Note that changing the name of the toolchain might break some existing tools where it's hard-coded.

@compnerd
Copy link
Member Author

compnerd commented Jun 1, 2023

Yeah, there is no good way around that. If they hardcoded the values, they knew this was likely to happen.

@compnerd compnerd merged commit 8939baf into swiftlang:main Jun 1, 2023
@compnerd compnerd deleted the versioning branch June 1, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants