Fetching user/group info causes race conditions #994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
parkera
reviewed
Oct 22, 2024
| } | ||
| } | ||
|
|
||
| static func uidFor(name: String) -> uid_t? { |
There was a problem hiding this comment.
We don't have to block this PR on it, but I think the more canonically named version with be uid(forName name: String) (etc.)
parkera
approved these changes
Oct 22, 2024
|
@swift-ci please test |
|
@swift-ci please test |
jmschonfeld
added a commit
to jmschonfeld/swift-foundation
that referenced
this pull request
Oct 23, 2024
* Avoid racy stdlib functions for fetching user/group info * Refactor naming * Fix build failure
jmschonfeld
added a commit
that referenced
this pull request
Oct 23, 2024
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
* Avoid racy stdlib functions for fetching user/group info * Refactor naming * Fix build failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We call a variety of functions like
getpwnam/getpwuid/getgrgidto fetch information about users and groups. These functions are not thread safe (causing crashes during execution of the functions) and also return inner pointers which can be overwritten out from under us. To resolve these race conditions, this switches to the_rvariants of the functions which use a client-supplied buffer for populating the result. I consolidated these calls into functions on thePlatformnamespace and updated call sites throughout swift-foundation to avoid the functions that can race.Resolves #982