Skip to content

[6.0] [CMake] Fix macro install rpath #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jmschonfeld
Copy link
Contributor

Explanation: Fixes the rpath value for the Foundation macro library in the toolchain
Scope: Should only modify the rpath value for the macro library which is currently only built on linux
Original PR: #793
Risk: Minimal - minor change to fix an already-broken rpath value for a macro library which no other toolchain components are using yet
Testing: Testing done via local build and validation of the rpath as well as swift-ci toolchain builds and testing
Reviewer: @iCharlesHu

@jmschonfeld jmschonfeld requested a review from parkera July 29, 2024 23:17
@jmschonfeld
Copy link
Contributor Author

@swift-ci please test

@jmschonfeld jmschonfeld merged commit ebd0f42 into swiftlang:release/6.0 Aug 1, 2024
3 checks passed
@jmschonfeld jmschonfeld deleted the 6.0/cmake/fix-macro-rpath branch August 1, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants