Add an upcall point to swift-corelibs-foundation for String encoding conversion #1217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Will, of course, need a follow up in swift-corelibs-foundation to replace the function with one that calls into |
jmschonfeld
reviewed
Mar 19, 2025
| @@ -91,6 +91,14 @@ extension UInt16 { | |||
|
|
|||
| // These provides concrete implementations for String and Substring, enhancing performance over generic StringProtocol. | |||
|
|
|||
| #if !FOUNDATION_FRAMEWORK | |||
| @_spi(SwiftCorelibsFoundation) | |||
| dynamic public func _cfStringEncodingConvert(string: String, using encoding: UInt, allowLossyConversion: Bool) -> Data? { | |||
There was a problem hiding this comment.
Should we add a similar up-call for the bytes --> String direction so that we support decoding as well?
|
@swift-ci test |
jmschonfeld
approved these changes
Mar 19, 2025
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an upcall to swift-corelibs-foundation for converting String encodings that swift-foundation does not implement.
Partially resolves #1216.