Revise doc comments for API reference style (Swift 5.7-04182022) #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix spelling error in parameter name (invertion --> inversion). - Add docs for parameters and return values. - Use indicative instead of imperative for method/function/initializer abstracts. (Match a regex. --> Matches a regex.) - Don't use code voice in abstracts, or symbol names as English nouns. - Use contractions per Apple style. - Turn /// comments that contain notes for this API's implementers into plain // comments, to omit that content from the docs. Move them before the /// comments, to keep doc comments immediately adjacent to the declaration they documents. (cherry picked from commit ab308ee)
Co-authored-by: Nate Cook <[email protected]> (cherry picked from commit 96df14d)
amartini51
force-pushed
the
amartini/docs_91301229_5.7-04182022
branch
from
857a130 to
6fbe2c5
Compare
|
@milseman Thanks for reviewing the main PR. I've confirmed locally that this PR has the same set of changes. Is there anything else I should do before merging this one? |
|
We need high-level sign off on this if it's even possible to land at this point |
|
Do we have this on 5.7 as well? |
|
I don't think so, no |
|
Let's please get a clone for 5.7 up so that this at least gets into a later beta. @amartini51 can you take care of that? |
|
Re-cherry-picked for the Swift 5.7 branch in #378. Looks like it's too late in the release process to do anything with this PR, so closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #350