Add wholeMatch and prefixMatch
#286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree that if these are on String/Substring, they should instead be generic like the others. I weakly hold that they should exist, but I appreciate @natecook1000's perspective, especially if we have anchoring modifier APIs on |
Add the functions to string processing algorithms proposal and implement the change. Move the functions from `String` and `SubString` extensions to `BidirectionalCollection`. Add tests for `firstMatch`, `wholeMatch`, and `prefixMatch` that use a custom `BidirectionalCollection` type.
itingliu
force-pushed
the
whole-match-prefix-match
branch
from
00c4021 to
4b5da35
Compare
|
@swift-ci please test |
milseman
approved these changes
Apr 21, 2022
| @@ -473,7 +484,7 @@ extension RangeReplaceableCollection where SubSequence == Substring { | |||
| /// - Returns: A new collection in which all occurrences of subsequence | |||
| /// matching `regex` in `subrange` are replaced by `replacement`. | |||
| public func replacing<R: RegexComponent, Replacement: Collection>( | |||
| _ regex: R, | |||
| _ r: R, | |||
There was a problem hiding this comment.
Why this change? It makes the doc comment above invalid
| extension String { | ||
| extension BidirectionalCollection where SubSequence == Substring { | ||
| /// Match a regex in its entirety. | ||
| /// - Parameter r: The regex to match against. |
There was a problem hiding this comment.
Hmm... potential parameter names could be regex or pattern or regexComponent....
WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the functions to string processing algorithms proposal and implement the
change.
Move the functions from
StringandSubStringextensions toBidirectionalCollection. Add tests forfirstMatch,wholeMatch, andprefixMatchthat use a customBidirectionalCollectiontype.