Improve nrfx-blink-sdk example to automatically get Zephyr defines and show using nrfutil instead of nrfjprog #130
Conversation
|
Ignore the "Update Swift Version / Create or update PR (pull_request)" failure. That workflow shouldn't run on PRs, the fix is here: #131 |
|
@kubamracek can you review this one? |
|
@xtremekforever it looks like the zephyr build is broken due to an upstream change, and im not sure how to resolve it. is this something you could look into? |
|
I'm disabling CI for Zephyr here to unblock other PRs: #136 |
Is it from a Zephyr change or a Swift change? I've run into issues when checking out newer Zephyr versions before, so I ended up locking it to v4.1 for all my workspaces. |
Seems to be a zephyr change, do you think you could help us pin the zephyr version(s) used in this repo? I'm not familiar with all the places pins are needed. |
rauhul
force-pushed
the
feature/improve-nrfx-blink-sdk-example
branch
from
85c278d to
b45e395
Compare
|
Sure @rauhul let me have a look tonight. If I find a solution I can PR separately to this repo to fix the issue. |
rauhul
force-pushed
the
feature/improve-nrfx-blink-sdk-example
branch
from
aa26195 to
5eeeac3
Compare
Removes hardcoded Zephyr -D flags in favor of defines from the zephyr_interface target. Replaces use of nrfjprog with nrfutil in both documentation and example usage.
@kubamracek I figured out how to get the Zephyr defines programmatically in CMakeLists.txt so that they don't have to be hardcoded. Please have a look!
-D__ZEPHYR__=1,-DKERNEL, etc), we dynamically grab them from thezephyr_interface INTERFACE_COMPILE_DEFINITIONSand set -Xcc flags for Swift compilation instead.nrfutilinstead ofnrfjprog.@rauhul I have also been working on an
Integration with Zephyrdocument for this repo, but still in progress. I'm hoping to have something soon in the next few weeks that we can look at.