[Macros] Set -external-plugin-path when the toolchain is not Xcode #1320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
commented
Mar 29, 2023
| fileSystem.exists(xcodePluginPath) | ||
| { | ||
| commandLine.appendFlag(.externalPluginPath) | ||
| commandLine.appendFlag(xcodePluginPath.pathString + "#" + xcodePluginPath.pathString) |
There was a problem hiding this comment.
This is not safe because xcodePluginServerPath can contain #.
@artemcm I want to pass a pair of /path/to/usr/bin/swift-plugin-server and /path/to/usr/lib/swift/host/plugins paths.
Is squashedArgumentList usable for this purpose? Does swift-frontend have a way to correctly "unpack" those values?
rintaro
force-pushed
the
macros-external-plugin-path
branch
from
faa70f5 to
7c0946f
Compare
artemcm
reviewed
Mar 30, 2023
| // default toolchain. | ||
| if | ||
| isFrontendArgSupported(.externalPluginPath), | ||
| let darwinToolchain = toolchain as? DarwinToolchain, |
There was a problem hiding this comment.
Can we instead move this to addPlatformSpecificCommonFrontendOptions, please?
artemcm
approved these changes
Mar 30, 2023
rintaro
force-pushed
the
macros-external-plugin-path
branch
from
7c0946f to
168d09b
Compare
rintaro
force-pushed
the
macros-external-plugin-path
branch
from
168d09b to
53ad3a9
Compare
|
@swift-ci Please test |
This was referenced Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://108525615